[MRESOLVER-321] Resolver while collecting may end up in busy loop without any possibility to be stopped

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.0.0-alpha-3, 2.0.0
• Component/s: Resolver
• Assignee: Tamas Cservenak
• Reporter: Tamas Cservenak
• Created: 14/Feb/23 18:54
• Updated: 27/Nov/23 22:10
• Resolved: 27/Nov/23 14:24

Description

As reported by users, under some conditions (MRESOLVER-316) resolver is able to spin itself into busy loop, without possibility to stop it (ie. by interrupting the thread of it).

Example report: https://github.com/apache/maven-resolver/pull/236

The reproducer (until MRESOLVER-316 is fixed) is present in PR above (the demo code and the diff for it).

While the PR proposes a code change, that is not covering all, as in case of MRESOLVER-316 bug, the endless loop happens in visitor bit (DependencyVisitor visiting DependencyNodes).

Solutiom: make collector but also visitor sense thread interruption.

Issue Links

• links to: GitHub Pull Request #380