[MRESOLVER-317] Improvements for BF collector

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.9.5
• Component/s: Resolver
• Assignee: Tamas Cservenak
• Reporter: Tamas Cservenak
• Created: 02/Feb/23 08:21
• Updated: 02/Feb/23 21:57
• Resolved: 02/Feb/23 21:57

Description

The BF collector should receive following improvements:

• make skipper Closeable
• make ParallelDescriptorResolver Closeable
• improve encapsulation of ParallelDescriptorResolver (make fields private final)
• the doCollectDependencies method should use the two closeables within try-with-resource block

Currently there may be resource leak (thread pool) if doCollectDependencies method throws, as resolver will not be shut down (skipper does not hold resources, but logic is same).

Issue Links

• links to: GitHub Pull Request #238