[MRESOLVER-265] Discrepancy between produced and recognized checksums

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.8.0
• Fix Version/s: 1.8.2
• Assignee: Tamas Cservenak
• Reporter: Tamas Cservenak
• Created: 24/Jun/22 08:31
• Updated: 23/Jul/22 19:05
• Resolved: 24/Jun/22 19:18

Description

In short: repository layout has member:

• org.eclipse.aether.internal.impl.Maven2RepositoryLayoutFactory.Maven2RepositoryLayout#checksumAlgorithms

That is checksums (as configured by user of default) that will be consumed (on fetch) or produced (publish).

Now, if we consider "default" configured resolver (checksumAlrgorithms=SHA1, MD5) there is a discrepancy IF ANY OTHER supported but not configured checksum comes in play:

If a Mojo attaches an artifact having extension ".zip.sha512", resolver will checksum it (w/ checksumAlgorithms checksums) DESPITE it should know this is a checksum, and "checksum of a checksum" is a nonsense, just makes noise.

Reason: method org.eclipse.aether.internal.impl.Maven2RepositoryLayoutFactory.Maven2RepositoryLayout#isChecksum works with preconfigured checksums only (in our example SHA1 and MD5) and will respond "not a checksum" for SHA512.

Proposal to fix:
The method check should NOT be based on checksumAlgorithms but on "all checksums supported by Resolver".

Issue Links

• is depended upon by: MRESOLVER-246 m-deploy-p will create hashes for hashes
• links to: GitHub Pull Request #187