[MRESOLVER-25] Resume support is broken under high concurrency

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Maven Artifact Resolver 1.0.3
• Fix Version/s: 1.5.0, 1.6.0, 1.6.1
• Component/s: Resolver
• Assignee: Michael Osipov
• Reporter: Roland Illig
• Created: 13/Jan/17 10:10
• Updated: 01/Oct/20 06:51
• Resolved: 18/Jul/20 11:56

Description

When building a multi-module project in parallel, Maven updates the local Maven repository without taking into account that other threads or processes might do the same at the same time.

To reproduce:

1. unpack the attached project
2. mvn dependency:list -U -B -T100

See the attached dependency-list.txt for an example output.

First thing to notice is that the dependency is downloaded 100 times. This is unexpected, since the Reactor should coordinate all the modules.

Second thing to notice is that the build fails, since a dependency "cannot be found". This is wrong, since the dependency can be found, it's just not processed properly.

I suspect the legacy.DefaultWagonManager to be the cause of this, since the typical error messages are:

• "Downloaded file does not exist: "
• "Error copying temporary file to the final destination: "
• "*** CHECKSUM FAILED - RETRYING"

Issue Links

• causes: MRESOLVER-134 Unsatisfiable Range header causing 416 HTTP error
• is duplicated by: MRESOLVER-65 When the build is run in parallel there are unsafe concurrent changes in the local repo
• is fixed by: MRESOLVER-123 Provide a global locking sync context by default
• is fixed by: MRESOLVER-131 Introduce a Redisson-based SyncContextFactory