[MRESOLVER-236] Make it possible to resolve .asc on a 'fail' <checksumPolicy/> respository.

• Type: New Feature
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.7.3
• Fix Version/s: 1.8.0
• Component/s: Resolver
• Assignee: Tamas Cservenak
• Reporter: Rod Widdowson
• Created: 24/Jan/22 10:46
• Updated: 16/Mar/22 00:21
• Resolved: 15/Mar/22 17:59

Description

(I'm guessing the resolver version - maven version is 3.8.4).

We accidently made one of our repositories <checksumPolicy>fail</checksumPolicy> some time ago and over the weekend an plugin we run started failing.

After some digging I discovered that the problem was when the code was programmatically trying to resolve a jar.asc file. Eventually the code ended up in

org.eclipse.aether.internal.impl.Maven2RepositoryLayoutFactory line 196

        public List<Checksum> getChecksums {
            if ( isSignature( artifact.getExtension() ) )
            {
                return Collections.emptyList();
            }

This means that when the resolution hit the correct repository it (silently) failed the checksum check and moved on to the next one, eventually falling off the end of the list and failing to resolve.

Our work around is to set the <checksumPolicy> to warn (which is what it used to be).

'It would be nice if'

• The failure was slightly less quiet
• If it was possible - programmatically or by configuration - to resolve signatures from checksuming repositories.

I have not dived very deeply into the code - just enough to diagnose why our CI was exploding so spectacularly so I may have missed some trick in which case I apologise for asking for existing function

Issue Links

• is caused by: MRESOLVER-241 Resolver checksum calculation should be driven by layout
• is caused by: MRESOLVER-242 When no remote checksums provided by layout, transfer inevitably fails/warns
• links to: GitHub Pull Request #159