[MRESOLVER-177] Move pre-/post-processing of metadata from ResolveTask to DefaultMetadataResolver

• Type: Task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.6.2
• Fix Version/s: 1.6.3, 1.7.0
• Component/s: Resolver
• Assignee: Tamas Cservenak
• Reporter: Michael Osipov
• Created: 04/May/21 08:40
• Updated: 15/Dec/21 15:16
• Resolved: 04/May/21 12:51

Description

Using the ResolveTask on the same metadata file from multiple repositories creates a race condition on resolver-status.properties because no worker thread is holding a lock on that file while the parent (waiting) thread holds a lock on the metadata item only.
We don't want to introduce any synchronization in the tracking file manager because it is almost always called from within a synchronized context. Instead we are inlining (moving) the pre-/post-processing of metadata into the caller thread and will leave the sole download (safe) handling ot the ResolveTask.

Issue Links

• fixes: MRESOLVER-153 resolver-status.properties file is corrupted due to concurrent writes
• is related to: MRESOLVER-132 Remove synchronization in TrackingFileManager
• is required by: MRESOLVER-153 resolver-status.properties file is corrupted due to concurrent writes
• relates to: MRESOLVER-216 [ERROR] Malformed \uxxxx encoding.