Uploaded image for project: 'Maven Resolver'
  1. Maven Resolver
  2. MRESOLVER-164

DefaultDependencyCollector filterVersions seems always return full version range

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 1.4.2, 1.6.1
    • 2.0.0-alpha-5, 2.0.0
    • Resolver
    • None

    Description

      Related to MNG-7049 but I think the root cause is in maven-resolver so I opened a new issue. Correct me if it is better to still use the old ticket.

      During using version ranges, I notice that maven will download all poms from a version range, which happen in that loop, the reason is that verFilter here seems return null. Since by default, versionFilter is set to null by DefaultRepositorySystemSession, and I do not see many examples that setVersionFilter get used for some reason. 

      Another thing that confuses me is that version range is resolved by DefaultVersionRangeResolver in maven rather than maven-resolver here.

       

      I wonder if it possible to set HighestVersionFilter here instead of return all version range results. I am happy to contribute a PR with some guidance.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              xiangli1996 Xiang Li
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: