Uploaded image for project: 'Maven Resolver'
  1. Maven Resolver
  2. MRESOLVER-157

Get rid of ServiceLocator in Resolver

    XMLWordPrintableJSON

Details

    • Task
    • Status: Open
    • Major
    • Resolution: Unresolved
    • None
    • None
    • Resolver
    • None

    Description

      maven-resolver currently supports:

      • ServiceLocator
      • "vanilla" Guice (provides a module)
      • DI using Sisu, as used in Maven

      IMO, it makes not much sense to support 3 vastly different "DI"s (in quotes as ServiceLocator is really just a dumb factory pattern).

      Not only just complicates the code base, makes changes error prone at least, yields for "exceptions" (this or that will never work with it, as seen with SyncContext), and, for me most importantly, prevents proper constructor initialization and validation of components.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              cstamas Tamás Cservenák
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated: