Uploaded image for project: 'Maven Resolver'
  1. Maven Resolver
  2. MRESOLVER-157

Get rid of ServiceLocator in Resolver

Agile BoardAttach filesAttach ScreenshotAdd voteVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Task
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Resolver
    • Labels:
      None

      Description

      maven-resolver currently supports:

      • ServiceLocator
      • "vanilla" Guice (provides a module)
      • DI using Sisu, as used in Maven

      IMO, it makes not much sense to support 3 vastly different "DI"s (in quotes as ServiceLocator is really just a dumb factory pattern).

      Not only just complicates the code base, makes changes error prone at least, yields for "exceptions" (this or that will never work with it, as seen with SyncContext), and, for me most importantly, prevents proper constructor initialization and validation of components.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              cstamas Tamás Cservenák

              Dates

              • Created:
                Updated:

                Issue deployment