[MRELEASE-982] Wrong log message when setting suppressCommitBeforeTagOrBranch to true

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 2.3, 2.4, 2.5
• Labels: log
• Assignee: Elliotte Rusty Harold
• Reporter: Stefan Prietl
• Created: 09/Mar/17 12:32
• Updated: 10/Apr/20 18:50
• Resolved: 10/Apr/20 18:50

Description

When setting suppressCommitBeforeTagOrBranch to true it actually logs the following:

[INFO] Modified POMs are not committed because suppressCommitBeforeTagOrBranch is set to false.

The "error" in this case seems to be a misinterpreted else clause in the code of ScmCommitPreparationPhase.java (line 62).

This is a minor annoyance when trying to find the cause of a released pom not being updated in the VCS' tag and seeing this paradox message in the log file.

Actually, the patch in issue MVN-745 provided by my doppelganger seder would fix this.

Issue Links

• links to: GitHub Pull Request #39