Uploaded image for project: 'Maven Release Plugin'
  1. Maven Release Plugin
  2. MRELEASE-982

Wrong log message when setting suppressCommitBeforeTagOrBranch to true

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.3, 2.4, 2.5
    • Fix Version/s: None
    • Component/s: None
    • Labels:

      Description

      When setting suppressCommitBeforeTagOrBranch to true it actually logs the following:

      [INFO] Modified POMs are not committed because suppressCommitBeforeTagOrBranch is set to false.
      

      The "error" in this case seems to be a misinterpreted else clause in the code of ScmCommitPreparationPhase.java (line 62).

      This is a minor annoyance when trying to find the cause of a released pom not being updated in the VCS' tag and seeing this paradox message in the log file.

      Actually, the patch in issue MVN-745 provided by my doppelganger Stefan Eder would fix this.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                elharo Elliotte Rusty Harold
                Reporter:
                ederst Stefan Prietl
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 20m
                  20m