Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Auto Closed
    • 2.3.2
    • None
    • branch, Git
    • None

    Description

      The branch mojo produces <tag>HEAD</tag>. This can't be right; HEAD isn't the name of a branch, it's the name of a ref.

      Attachments

        Activity

          http://maven.apache.org/pom.html#SCM

          This is kind of a legacy matter, when the pom.xml was designed git didn't exist.

          It would be better however if the actual original value was restored, rather than the "effective model" value of "HEAD" when the <tag> element was not present before.

          dlmiles Darryl L. Miles added a comment - http://maven.apache.org/pom.html#SCM This is kind of a legacy matter, when the pom.xml was designed git didn't exist. It would be better however if the actual original value was restored, rather than the "effective model" value of "HEAD" when the <tag> element was not present before.

          The maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java#buildScm(MavenProject) is the location the <scm> data is restored.

          It is not clear how to know if the element was not present before to be able to call scm.setTag(null).

          dlmiles Darryl L. Miles added a comment - The maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java#buildScm(MavenProject) is the location the <scm> data is restored. It is not clear how to know if the element was not present before to be able to call scm.setTag(null).

          Patch to GIT maven-release.git trunk a603d07

          This patch copies what CVS does in the situation.

          dlmiles Darryl L. Miles added a comment - Patch to GIT maven-release.git trunk a603d07 This patch copies what CVS does in the situation.
          bhamail Dan Rollo added a comment -

          I found the way the release-plugin adds the <tag>HEAD</tag> when no prior <tag> element existed surprising. The behavior described for the patch seems more logical (and is less surprising).

          bhamail Dan Rollo added a comment - I found the way the release-plugin adds the <tag>HEAD</tag> when no prior <tag> element existed surprising. The behavior described for the patch seems more logical (and is less surprising).
          michael-o Michael Osipov added a comment -

          This issue has been auto closed because it has been inactive for a long period of time. If you think this issue still applies, retest your problem with the most recent version of Maven and the affected component, reopen and post your results.

          michael-o Michael Osipov added a comment - This issue has been auto closed because it has been inactive for a long period of time. If you think this issue still applies, retest your problem with the most recent version of Maven and the affected component, reopen and post your results.

          People

            Unassigned Unassigned
            bmargulies Benson Margulies
            Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: