[MRELEASE-750] String index out of range: -1 in ReleaseUtils.loadResolvedDependencies() when using Parent-Module-Layout

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.3
• Fix Version/s: 2.4
• Component/s: prepare
• Flags: Patch
• Assignee: Robert Scholte
• Reporter: Thomas Baldauf
• Created: 23/Mar/12 07:55
• Updated: 17/Aug/18 09:07
• Resolved: 17/Aug/18 09:07

Description

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-release-plugin:2.XXX:prepare (default-cli) on project XXX: Execution default-cli of goal org.apache.maven.plugins:maven-release-plugin:2.XXX:prepare failed: String index out of range: -1 -> [Help 1]

This is happening in org.apache.maven.shared.release.config.ReleaseUtils.loadResolvedDependencies(..),
line number 250:

artifactVersionlessKey = propertyName.substring( startIndex, endIndex );

Apparently endIndex can be -1 under special circumstances. Defensive programming fixes the problem.

Proposed patch (see attachment):

if (endIndex > startIndex)

{ artifactVersionlessKey = propertyName.substring( startIndex, endIndex ); }

else

{ artifactVersionlessKey = propertyName.substring( startIndex ); }