[MPLUGIN-330] If and else-if branches has the same condition

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.5
• Fix Version/s: 3.5.1
• Component/s: Plugin Plugin
• Assignee: Herve Boutemy
• Reporter: songwanging
• Created: 08/Dec/17 17:26
• Updated: 06/Jan/18 02:03
• Resolved: 06/Jan/18 02:03

Description

Our tool DeepTect has detected a piece of buggy code snippet, in which the if and else branches has the same condition.

Path: maven-plugin-tools/maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/AbstractGeneratorMojo.java

public void execute(){
...
Set<Artifact> requestDependencies;
        if ( mojoDependencies == null )
        {
            requestDependencies = dependencies;
        }
        else if ( mojoDependencies == null )
        {
            requestDependencies = null;
        }
...
}

Issue Links

• is related to: MPLUGIN-305 MojoAnnotationsScanner should have better control over dependency scanning