Maven Project Info Reports Plugin
  1. Maven Project Info Reports Plugin
  2. MPIR-85

Refactoring of dependency and dependency management report

    Details

    • Flags:
      Patch

      Description

      I've tried to refactor the code from MPIR-83 a bit, because it used a lot of copied code.

      Important improvements:

      • Created a AbstractProjectInfoRenderer and AbstractDependencyRenderer.
        If this patch is accepted, I want to write all the renderers out of the inforeports in separate classes, with more code sharing. This is a start of that.
      • I changed the unit tests, because the expected and actual were reversed. This is the case in many of the info report unit tests.

      Please tell me what you think of it. I know it is only a start.

      1. comparators.patch
        27 kB
        Nick Stolwijk
      2. refactor.patch
        114 kB
        Nick Stolwijk
      3. refactor.patch
        114 kB
        Nick Stolwijk

        Activity

        Nick Stolwijk created issue -
        Nick Stolwijk made changes -
        Field Original Value New Value
        Attachment refactor.patch [ 33002 ]
        Nick Stolwijk made changes -
        Attachment comparators.patch [ 33003 ]
        Dennis Lundberg made changes -
        Component/s dependencies [ 13326 ]
        Component/s dependency-management [ 13328 ]
        Hervé Boutemy made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Assignee Herve Boutemy [ hboutemy ]
        Resolution Fixed [ 1 ]
        Fix Version/s 2.4 [ 17000 ]
        Mark Thomas made changes -
        Project Import Sun Apr 05 12:10:01 UTC 2015 [ 1428235801085 ]
        Mark Thomas made changes -
        Workflow jira [ 12723359 ] Default workflow, editable Closed status [ 12756052 ]
        Mark Thomas made changes -
        Patch Submitted Yes [ 10763 ]
        Flags Patch [ 10430 ]
        Mark Thomas made changes -
        Project Import Mon Apr 06 00:45:01 UTC 2015 [ 1428281101090 ]
        Mark Thomas made changes -
        Workflow jira [ 12961216 ] Default workflow, editable Closed status [ 12998265 ]

          People

          • Assignee:
            Hervé Boutemy
            Reporter:
            Nick Stolwijk
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development