[MPIR-293] On the team list report the "picUrl" property appears in the table, although no other properties are set for that team member

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.7
• Fix Version/s: 2.8
• Flags: Patch
• Assignee: stephenconnolly
• Reporter: Anghel Botos
• Created: 27/Sep/13 14:33
• Updated: 05/Apr/15 14:54
• Resolved: 22/May/14 08:07

Description

On the team list report the "picUrl" property appears in the table, although no other properties are set for that team member.

Given the following team list in the pom.xml:

 
    <developers>
        <developer>
            <id>abotos</id>
            <name>Anghel Botos</name>
            <email>[e-mail]</email>
            <properties>
                <picUrl>images/avatars/abotos.png</picUrl>
            </properties>
        </developer>
    </developers>

Due to the following lines of code in TeamListReport.java:

TeamListReport.java

                Properties properties = unit.getProperties();
                boolean hasPicUrl = properties.contains( "picUrl" );
                if ( hasPicUrl )
                {
                    requiredHeaders.put( IMAGE, Boolean.TRUE );
                }
                boolean isJustAnImageProperty = properties.size() == 1 && hasPicUrl;
                if ( !isJustAnImageProperty && !properties.isEmpty() )
                {
                    requiredHeaders.put( PROPERTIES, Boolean.TRUE );
                }

hasPicUrl evaluates to false because the check is done using contains not containsKey, and thus isJustAnImageProperty evaluates also to false leading to the Properties column being added to the team members table and the picUrl property being displayed in that column in the table, although the Properties column should not be present for this case.

Issue Links

• is depended upon by: MPIR-277 picUrl displays image but also causes Properties column to appear