[MPIR-221] Fix for MPIR-171 generates unnecessary and confusing warnings for non-integral time-zones

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.3.1
• Fix Version/s: 2.4
• Assignee: Herve Boutemy
• Reporter: Sebb
• Created: 11/Feb/11 15:08
• Updated: 07/Apr/15 18:54
• Resolved: 02/May/11 15:01

Description

The change for MPIR-171 added a check to see if the timezone is numeric. If not, it reports a warning.

However, the check fails to allow for non-integral timezones - e.g. 5.5 - and the warning message is incorrect, as it does not show the correct information.

For example, the following setting:

<developer>
<timezone>+5.5</timezone>
</developer>

results in the warning:

[WARNING] The time zone '-2147483648' for the developer 'Name' is not a recognised time zone, use a number in the range -12 to +14 instead of.

The message should read something like:

[WARNING] The time zone '+5.5' for the developer 'Name' is not a recognised time zone, use a number in the range -12 to +14 or a valid long TimeZone id.

except that it should not be generated for that particular timezone, as +5.5 is as valid as +5 (which does not generate a warning).

To summarise:
1) the warning message is not helpful, as it does not show the correct timezone.
2) the warning should not be generated for fractional timezones.