[MPIR-178] some reports have inconsistent line ending style

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.1.2
• Component/s: dependencies, team
• Environment: Windows
• Assignee: Unassigned
• Reporter: Oleg Estekhin
• Created: 23/Nov/09 06:05
• Updated: 06/Apr/15 01:19
• Resolved: 08/Feb/10 16:08

Description

Some of the reports generated by the plugin have inconsistent line ending style. I have marked dependency and team-list components as affected by probably other components can produce inconsistent line endings too.

I am working on Windows so it is (somewhat) expected that files generated by the plugin will have the CRLF line ending, but some files will have a mixed line ending style due to different reasons.

The plugin should enforce consistent line ending style in the output files. It is possible that this issue is not caused by the plugin itself but "inherited" from some of its dependencies that handle generic maven reporting functionality, in this case please move the issue to the appropriate maven component.

Examples:

team-list.html
The following code fragment near the end of the file seems to always have the LF line endings:

<script type="text/javascript">
function offsetDate(id, offset) {
    var now = new Date();
    var nowTime = now.getTime();
    var localOffset = now.getTimezoneOffset();
    var developerTime = nowTime + ( offset * 60 * 60 * 1000 )+ ( localOffset * 60 * 1000 );
    var developerDate = new Date(developerTime);

    document.getElementById(id).innerHTML = developerDate;
}

function init(){
}

window.onLoad = init();
</script>

This code is probably copied to the resulting report page from some string literal with hard-coded line ending.

dependencies.html
The dependency report contains a dependency tree that has an "I" icon that unhides a description of a particular dependency. The description text is obtained from somewhere (the dependency pom?) and copied to the dependencies.html as is, including its line ending style.

For example, org.antlr:stringtemplate:jar:3.2 and antlr:antlr:jar:2.7.7 dependencies have a description that uses LF line endings. When these artifacts are required either directly or indirectly then the project's dependencies.html will contain both CRLF for generated code and LF for copy-pasted descriptions.
Check the http://maven-svn-wagon.googlecode.com/svn/site/dependencies.html, lines 450-464 for the specific example.

Issue Links

• is related to: MSITE-121 Generated html files contain inconsistent new lines
• is related to: MPIR-35 Site Plugin should work from Template. Plugin Should not generate Markup from Java