[MODPYTHON-216] Code for deriving base URL/directory for request using wrong value???

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 3.3.x
• Component/s: core
• Assignee: Unassigned
• Reporter: Graham Phillip Dumpleton
• Created: 26/Jan/07 23:41
• Updated: 26/Jan/07 23:41

Description

In determine_context() of src/mod_python.c, the code pertaining to Directory has:

if (!strcmp(directory, "~"))

{ directory = ap_getword_conf(p, &arg); d_regex = ap_pregcomp(p, cmd->path, AP_REG_EXTENDED|USE_ICASE); }

else if (ap_is_matchexp(directory))

{ d_is_fnmatch = 1; }

and that for Location has:

if (!strcmp(location, "~"))

{ location = ap_getword_conf(p, &arg); l_regex = ap_pregcomp(p, cmd->path, AP_REG_EXTENDED|USE_ICASE); }

else if (ap_is_matchexp(location))

{ l_is_fnmatch = 1; }

In both cases, the pattern used to compile the regular expression is the value of cmd->path.

These perhaps should be 'directory' and 'location' respectively, but then cmd->path may be the same thing anyway.

No actual problems have been see with code because of this, but should be verified anyway.