[MNG-8340] Staged 4.0.0-beta5 broken by maven-shade-plugin

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.0.0-beta-5
• Fix Version/s: 4.0.0-rc-1
• Assignee: Guillaume Nodet
• Reporter: Mateusz Gajewski
• Created: 21/Oct/24 16:39
• Updated: 13/Nov/24 19:26
• Resolved: 13/Nov/24 15:15

Description

Reproduction: https://github.com/trinodb/trino/pull/23849

 

Project structure:

> pom.xml
> client/trino-cli/pom.xml (parent.relativePath = ../../pom.xml)

maven-shade-plugin writes trino-cli dependency reduced pom to:

${project.build.directory}/pom.xml -> client/trino-cli/target/pom.xml

The file contains:

<parent>
   <relativePath>../../../pom.xml</relativePath>
</parent>

which correctly points to root pom.xml
 
This worked under beta4, fails under beta5 with:

[ERROR]     - [FATAL] 'parent.relativePath' points at '../../../pom.xml' but no POM could be found, please verify your project structure @ line 3, column 3 

It seems that parent.relativePath is resolved against client/trino-cli instead of client/trino-cli/target where pom.xml is placed.

Issue Links

• is caused by: MNG-8294 Add a consistency check when loading parent
• links to: GitHub Pull Request #399
• links to: GitHub Pull Request #400
• links to: GitHub Pull Request #1857