[MNG-7678] Settings (v3) and Settings.Builder() cannot unset a non-null field

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.0.0-alpha-4
• Fix Version/s: 4.0.0-alpha-5, 4.0.0
• Component/s: Core, Settings
• Assignee: Guillaume Nodet
• Reporter: James Z.M. Gao
• Created: 04/Feb/23 12:39
• Updated: 20/Oct/23 07:57
• Resolved: 13/Mar/23 18:35

Description

 

Testing code:

    final Settings s = new Settings();

    s.setLocalRepository("xxx");
    assertEquals("xxx", s.getLocalRepository()); // OK

    s.setLocalRepository("yyy");
    assertEquals("yyy", s.getLocalRepository()); // OK

    s.setLocalRepository(null);
    assertNull(s.getLocalRepository()); // FAIL

 

It seems related to the the build() method of Model Builder with forceCopy = false :

 

${field.name} != null ? ${field.name} : ( base != null ? base.${field.name} : null )${sep}

 

Issue Links

• links to: GitHub Pull Request #983