[MNG-7640] Investigate which ITs really need to set system properties

• Type: Task
• Status: Closed
• Priority: Major
• Resolution: Done
• Component/s: Integration Tests
• Assignee: Michael Osipov
• Reporter: Michael Osipov
• Created: 20/Dec/22 08:08
• Updated: 02/Jan/23 19:39
• Resolved: 02/Jan/23 19:39

Description

We need to investigate and clean up all ITs which set system properties:

osipovmi@deblndw011x:~/var/Projekte/mit (master *=)
$ grep -r  setSystemProperty core-it-suite/src/test/java/
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4428FollowHttpRedirectTest.java:            verifier.setSystemProperty( "javax.net.ssl.trustStore", storePath );
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4428FollowHttpRedirectTest.java:            verifier.setSystemProperty( "javax.net.ssl.trustStorePassword", storePwd );
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng0848SystemPropOverridesDefaultValueTest.java:        verifier.setSystemProperty( "config.aliasDefaultExpressionParam", "PASSED" );
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng0786ProfileAwareReactorTest.java:        verifier.setSystemProperty( "expression.outputFile", "target/expression.properties" );
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng0786ProfileAwareReactorTest.java:        verifier.setSystemProperty( "activate", "anything" );
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng2136ActiveByDefaultProfileTest.java:        verifier.setSystemProperty( "expression.outputFile", new File( testDir, "target/expression.properties" ).getPath() );
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng2136ActiveByDefaultProfileTest.java:        verifier.setSystemProperty( "expression.expressions", "project/properties" );
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng2305MultipleProxiesTest.java:            verifier.setSystemProperty( "javax.net.ssl.trustStore", storePath );
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng2305MultipleProxiesTest.java:            verifier.setSystemProperty( "javax.net.ssl.trustStorePassword", storePwd );
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng2305MultipleProxiesTest.java:            verifier.setSystemProperty( "maven.artifact.threads", "1" );
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng2577SettingsXmlInterpolationTest.java:        verifier.setSystemProperty( "usr.MNGIT", "usr-prop-test" );
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4936EventSpyTest.java:        verifier.setSystemProperty( "maven.ext.class.path", "spy-0.1.jar" );
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng3004ReactorFailureBehaviorMultithreadedTest.java:        verifier.setSystemProperty( "maven.threads.experimental", "1" );
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng3004ReactorFailureBehaviorMultithreadedTest.java:        verifier.setSystemProperty( "maven.threads.experimental", "1" );
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng3004ReactorFailureBehaviorMultithreadedTest.java:        verifier.setSystemProperty( "maven.threads.experimental", "1" );
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng3004ReactorFailureBehaviorMultithreadedTest.java:        verifier.setSystemProperty( "maven.threads.experimental", "2" );
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng3004ReactorFailureBehaviorMultithreadedTest.java:        verifier.setSystemProperty( "maven.threads.experimental", "2" );
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng3379ParallelArtifactDownloadsTest.java:        verifier.setSystemProperty( "maven.artifact.threads", "16" );
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng0377PluginLookupFromPrefixTest.java:        verifier.setSystemProperty( "touch.outputFile", "target/file.txt" );
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4452ResolutionOfSnapshotWithClassifierTest.java:        verifier.setSystemProperty( "mng4452.type", "jar" );
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4452ResolutionOfSnapshotWithClassifierTest.java:        verifier.setSystemProperty( "mng4452.classifier", "unix" );
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4452ResolutionOfSnapshotWithClassifierTest.java:        verifier.setSystemProperty( "mng4452.type", "jar" );
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4452ResolutionOfSnapshotWithClassifierTest.java:        verifier.setSystemProperty( "mng4452.classifier", "win" );
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4452ResolutionOfSnapshotWithClassifierTest.java:        verifier.setSystemProperty( "mng4452.type", "war" );
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4452ResolutionOfSnapshotWithClassifierTest.java:        verifier.setSystemProperty( "mng4452.classifier", "win" );
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4469AuthenticatedDeploymentToCustomRepoTest.java:        verifier.setSystemProperty( "file", "settings.xml" );
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4469AuthenticatedDeploymentToCustomRepoTest.java:        verifier.setSystemProperty( "groupId", "org.apache.maven.its.mng4469" );
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4469AuthenticatedDeploymentToCustomRepoTest.java:        verifier.setSystemProperty( "artifactId", "it" );
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4469AuthenticatedDeploymentToCustomRepoTest.java:        verifier.setSystemProperty( "version", "0.1" );
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4469AuthenticatedDeploymentToCustomRepoTest.java:        verifier.setSystemProperty( "repositoryId", "mng4469" );
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4469AuthenticatedDeploymentToCustomRepoTest.java:        verifier.setSystemProperty( "repositoryUrl", "http://localhost:" + port + "/repo" );
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4590ImportedPomUsesSystemPropertiesTest.java:        verifier.setSystemProperty( "test.dir", testDir.getAbsolutePath() );
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4615ValidateRequiredPluginParameterTest.java:        verifier.setSystemProperty( "config.requiredParam", "CLI" );
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4625SettingsXmlInterpolationWithXmlMarkupTest.java:            verifier.setSystemProperty( "test.prop", "\"&x=y<>\"" );
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4625SettingsXmlInterpolationWithXmlMarkupTest.java:            verifier.setSystemProperty( "test.prop", "&x=y<>" );
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4765LocalPomProjectBuilderTest.java:        verifier.setSystemProperty( "user.prop", "OK" );
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng5011ConfigureCollectionArrayFromSystemPropTest.java:        verifier.setSystemProperty( "config.stringParams", "" );
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng5011ConfigureCollectionArrayFromSystemPropTest.java:        verifier.setSystemProperty( "config.fileParams", "foo,bar" );
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng5011ConfigureCollectionArrayFromSystemPropTest.java:        verifier.setSystemProperty( "config.listParam", ",two,,four," );
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng5208EventSpyParallelTest.java:        verifier.setSystemProperty( "maven.ext.class.path", "../spy/target/event-spy-0.0.1-SNAPSHOT.jar" );
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng0294MergeGlobalAndUserSettingsTest.java:            verifier.setSystemProperty( "org.apache.maven.global-settings", "global-settings.xml" );
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng6558ToolchainsBuildingEventTest.java:        verifier.setSystemProperty( "maven.ext.class.path", "spy-0.1.jar" );

Not all ITs really require system properties. They are fine with user properties.

Issue Links

• links to: GitHub Pull Request #220