Uploaded image for project: 'Maven'
  1. Maven
  2. MNG-7439

Make fields of CliRequest protected

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Open
    • Trivial
    • Resolution: Unresolved
    • 3.8.5
    • None
    • Command Line, Embedding
    • None

    Description

      Hi,

      currently the fields of 

      org.apache.maven.cli.CliRequest 

      have the default access modifier. As no setters are provided, custom modifications to e.g. multiModuleProjectDirectory can not be made without e.g. reflection or change of the system properties.

      As an implementation of CliRequest with bean properties (private fields, getters and setters) would be possibly a breaking change, I suggest to make the fields protected to enable proper subclassing for custom modifications.

      I would appreciate to make a PR if needed/wanted.

      Kind regards
      Thomas

      Attachments

        Activity

          People

            Unassigned Unassigned
            Thomas Zub Thomas Zub
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated: