[MNG-7432] [REGRESSION] Resolver session contains non-MavenWorkspaceReader

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 3.8.5
• Fix Version/s: 3.8.6, 3.9.0, 4.0.0-alpha-2, 4.0.0
• Assignee: Tamas Cservenak
• Reporter: Falko Modler
• Created: 15/Mar/22 21:33
• Updated: 20/Oct/22 08:11
• Resolved: 08/Apr/22 08:47

Description

As Resolver session contains non-MavenWorkspaceReader, the reactor models (already resolved w/ profiles applied) are re-built when using Resolver within Mojo, instead to get them via ReactorReader as expected. The rebuilt models will lack explicit (-P on CLI) profiles applied, as resolver itself is not maven aware, hence there is no way to "tell" resolver to apply them. Building reactor models w/ profiles applied is NOT done using resolver, but by Maven when loading up reactor, as profiles are NOT applied for downstream transitive dependencies (see discussion on MNG-1388 why).
—

The README of the following reproducer says it all:
https://github.com/aloubyansky/playground/tree/maven-3.8.5-profile-activation

Initially discussed here: https://github.com/quarkusio/quarkus/pull/24285#issuecomment-1067368625

Issue Links

• fixes: MNG-7467 [REGRESSION] Compilation failure with relocated transitive dependency
• fixes: MNG-7493 [REGRESSION] Resolving dependencies between submodules fails
• is caused by: MNG-7400 Allow more WorkspaceReaders to participate
• links to: GitHub Pull Request #296
• links to: GitHub Pull Request #695
• links to: GitHub Pull Request #706