[MNG-7400] Allow more WorkspaceReaders to participate

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.8.4
• Fix Version/s: 3.8.5, 4.0.0-alpha-2, 4.0.0
• Assignee: Michael Osipov
• Reporter: Christoph Läubrich
• Created: 29/Jan/22 08:15
• Updated: 20/Oct/22 08:11
• Resolved: 13/Feb/22 10:44

Description

Currently there are two kind of WorkspaceReaders the reactor one and the one obtained from the RepositorySystemSession (which is eed by an IDE scoped component in org.apache.maven.internal.aether.DefaultRepositorySystemSessionFactory).

In Tycho we have the demand to supply a WorkspaceReader as there is a so called "target platform" as the source of artifacts.

Now it does not seem correct to declare it as an IDE, and of course we don't want to block the IDE use-case.

Another issue is that at the time the IDE component is injected there is no session and thus a session scoped component won't work as well so even if we would use this we are rather "blind".

It would be good to have maven discover WorkspaceReaders as it discovers AbstractMavenLifecycleParticipants in the following way, right before the session is fixed:

for ( WorkspaceReader reader : getWorkspaceReader( session.getProjects() ) )
{
	//chain them together with the current workspace reader(s)
}

Issue Links

• causes: MNG-7432 [REGRESSION] Resolver session contains non-MavenWorkspaceReader
• is related to: MNG-7403 Support loading of ArtifactHandlers from project-scoped extensions
• links to: GitHub Pull Request #667
• links to: GitHub Pull Request #668