[MNG-7132] mirrorOf external:* external:http:* detect only 127.0.01 as local, missing IPv6, 127.x.y.z and other

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Assignee: Unassigned
• Reporter: Romain Manni-Bucau
• Created: 29/Mar/21 07:42
• Updated: 30/Mar/21 16:57

Description

DefaultMirrorSelector used in org.apache.maven.internal.aether.DefaultRepositorySystemSessionFactory#newRepositorySession does not implement isLocal properly - more exactly it only handles 2 particular cases whereas local can be way more numerous:

1. ipv4 case: 127.x.y.z (test can be has 4 segments separated by a dot and starts with 127.)
2. ipv6 case: starts with 1 and ends with 0 (see java.net.Inet6Address.Inet6AddressHolder#isLoopbackAddress)
3. host case: not sure we want to handle it but except localhost hardcoded string we could parse /etc/hosts (or windows specific location) too to resolve the ip without going through InetAddress - see next point) and use the ip with 1+2 rules.

this can be implemented as string parsing (faster) or reusing java.net.InetAddress#isLoopbackAddress (which can fallback in some resolution which can be slow at startup but works better overall and is easier).

 

Issue Links

• relates to: MNG-7116 Add support for mirror selector on external:http:*
• relates to: MNG-3461 Enhance Mirror definition syntax with external:*