[MNG-7127] NullPointerException in MavenCliTest.testStyleColors in JDK 16

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 3.8.2, 4.0.0-alpha-2, 4.0.0
• Component/s: Embedding, Integration Tests
• Labels: Java16 unit-test

Environment

> uname -a
Darwin 3c22fb7b8b51.ant.amazon.com 19.6.0 Darwin Kernel Version 19.6.0: Tue Jan 12 22:13:05 PST 2021; root:xnu-6153.141.16~1/RELEASE_X86_64 x86_64

> java --version
openjdk 16 2021-03-16
OpenJDK Runtime Environment Corretto-16.0.0.36.1 (build 16+36)
OpenJDK 64-Bit Server VM Corretto-16.0.0.36.1 (build 16+36, mixed mode, sharing)

• Assignee: Martin Kanters
• Reporter: Carlos Chacin
• Created: 23/Mar/21 04:41
• Updated: 20/Oct/22 08:11
• Resolved: 27/Mar/21 18:17

Description

Given

That I'm using JDK 16 to build https://github.com/apache/maven

When

Executing the command to build the project locally after the git clone

mvn clean verify

Then

There is a failed test

[ERROR] Tests run: 14, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.929 s <<< FAILURE! - in org.apache.maven.cli.MavenCliTest
[ERROR] testStyleColors  Time elapsed: 0.03 s  <<< ERROR!
java.lang.NullPointerException
	at org.apache.maven.cli.MavenCliTest.testStyleColors(MavenCliTest.java:327)

Possible cause:

In JDK 8 the method Paths.get used in ResolveFile.java#L47 is using internally:

public static Path get(String first, String... more) {
    return FileSystems.getDefault().getPath(first, more);
}

but in JDK 16

public static Path get(String first, String... more) {
    return Path.of(first, more);
}

Issue Links

• is duplicated by: MNG-7054 [Test] MavenCliTest.testStyleColors failed with Java 16 and 17
• is duplicated by: MNG-7124 java.lang.NullPointerException at org.apache.maven.cli.MavenCliTest.testStyleColors(MavenCliTest.java:327)
• links to: GitHub Pull Request #460