[MNG-7052] Do not allow symbols as first character of identifiers in the POM

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Fix Version/s: 4.0.x-candidate
• Component/s: Core
• Assignee: Unassigned
• Reporter: Martin Kanters
• Created: 09/Dec/20 10:59
• Updated: 26/Feb/21 07:32

Description

In the DefaultModelValidator we currently validate identifiers against a-zA-Z0-9-_.
Since Maven also allows operators to be used against an identifier, this can result in bugs or at least unexpected behavior for the user.

The minus operator can be used to deactivate a certain profile, so an example would be:

• A project having a profile with the id -id-of-profile
• A Maven invocation of mvn <goal> -P-id-of-profile.

The release of Maven 4 is a nice opportunity to restrict the first character of an id to be a-zA-Z0-9 . The other characters may still consist of those symbols.

This should apply to all identifiers that we support. The methods that need attention are:
DefaultModelValidator#validateId and DefaultModelValidator#validateIdWithWildcards.

Issue Links

• is caused by: MNG-7051 Optionally skip non-existing profiles
• is depended upon by: MNG-6862 Wrong command line analysis for joined profile activation
• is related to: MNG-7051 Optionally skip non-existing profiles
• is related to: MNG-7107 Relax recently introduced profile id validation