Uploaded image for project: 'Maven'
  1. Maven
  2. MNG-6799

avoid model interpolation instability risk: ensure StringVisitorModelInterpolator replaces StringSearchModelInterpolator

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.6.2
    • Fix Version/s: 3.6.3
    • Labels:
      None

      Description

      as discovered recently and shared on dev ML, in maven-model-builder, StringVisitorModelInterpolator introduced by MNG-6697 in Maven 3.6.2 is meant to replace StringSearchModelInterpolator
      but currently, both can be injected and the selection of one against the other depends on the order of generated CDI descriptors: if you're lucky, StringVisitorModelInterpolator appear first, but if you're not, StringSearchModelInterpolator will do instead.

      In addition, with Reproducible Builds being introduced in MNG-6789, the order that is introduced is String lexical order: StringSearchModelInterpolator is then before StringVisitorModelInterpolator then with Reproducible Builds we get the unwanted result in a reproducible way...

      we need to ensure that StringVisitorModelInterpolator will be used instead of StringSearchModelInterpolator

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                hboutemy Herve Boutemy
                Reporter:
                hboutemy Herve Boutemy
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: