[MNG-6799] avoid model interpolation instability risk: ensure StringVisitorModelInterpolator replaces StringSearchModelInterpolator

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.6.2
• Fix Version/s: 3.6.3
• Component/s: Inheritance and Interpolation
• Assignee: Herve Boutemy
• Reporter: Herve Boutemy
• Created: 06/Nov/19 10:40
• Updated: 17/Sep/20 21:09
• Resolved: 07/Nov/19 13:08

Description

as discovered recently and shared on dev ML, in maven-model-builder, StringVisitorModelInterpolator introduced by MNG-6697 in Maven 3.6.2 is meant to replace StringSearchModelInterpolator
but currently, both can be injected and the selection of one against the other depends on the order of generated CDI descriptors: if you're lucky, StringVisitorModelInterpolator appear first, but if you're not, StringSearchModelInterpolator will do instead.

In addition, with Reproducible Builds being introduced in MNG-6789, the order that is introduced is String lexical order: StringSearchModelInterpolator is then before StringVisitorModelInterpolator then with Reproducible Builds we get the unwanted result in a reproducible way...

we need to ensure that StringVisitorModelInterpolator will be used instead of StringSearchModelInterpolator

Issue Links

• depends upon: MNG-6697 Add a fast interpolator not using reflection
• is related to: MNG-6907 endless loop in StringSearchModelInterpolator
• is related to: MNG-6983 Plugin key can get out of sync with artifactId and groupId
• is required by: MNG-6789 Make Maven distribution build Reproducible