[MNG-6790] Redundant code in MavenCli.cliMerge

• Type: Task
• Status: Closed
• Priority: Trivial
• Resolution: Won't Fix
• Affects Version/s: 3.6.3
• Component/s: Embedding
• Assignee: Robert Scholte
• Reporter: Anatoly Zaretsky
• Created: 20/Oct/19 13:17
• Updated: 30/Nov/19 22:16
• Resolved: 29/Nov/19 14:17

Description

cliMerge has a code to append all unrecognized arguments (i.e. goals)
from maven.config to the resulting CommandLine object:

    private CommandLine cliMerge( CommandLine mavenArgs, CommandLine mavenConfig )
    {
        CommandLine.Builder commandLineBuilder = new CommandLine.Builder();

        // the args are easy, cli first then config file
        for ( String arg : mavenArgs.getArgs() )
        {
            commandLineBuilder.addArg( arg );
        }
        for ( String arg : mavenConfig.getArgs() )
        {
            commandLineBuilder.addArg( arg );
        }
...

But this code always does nothing since the result of maven.config parsing is checked
for absence of any such unrecognized arguments right before the merging
is performed:

    void cli( CliRequest cliRequest )
        throws Exception
    {
...
                mavenConfig = cliManager.parse( args.toArray( new String[0] ) );
                List<?> unrecongized = mavenConfig.getArgList();
                if ( !unrecongized.isEmpty() )
                {
                    throw new ParseException( "Unrecognized maven.config entries: " + unrecongized );
                }
...

Note to the above snippets: CommandLine.getArgs() is almost the same as CommandLine.getArgList() - the only difference is that getArgs() returns String[] while getArgList() returns List<String>.

Issue Links

• links to: GitHub Pull Request #296