[MNG-6729] StringSearchModelInterpolator introspects objects from Java API

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.6.2
• Component/s: Inheritance and Interpolation
• Assignee: Tibor Digana
• Reporter: Tibor Digana
• Created: 07/Aug/19 14:49
• Updated: 28/Mar/20 23:16
• Resolved: 09/Aug/19 14:07

Description

The current implementation of StringSearchModelInterpolator introspects Java objects, e.g. java.io.File. This fix stops introspecting such objects. See the unit test testNotInterpolateFile.

We found this issue when our build process failed with this warning on the console output:

junit.framework.AssertionFailedError: expected:<[]> but was:<[WARNING: An illegal reflective access operation has occurred, WARNING: Illegal reflective access by org.apache.maven.model.interpolation.StringSearchModelInterpolator$InterpolateObjectAction$CacheField (file:/home/jenkins/jenkins-slave/workspace/ven-box_maven_removed-java-tools/test/core-it-suite/target/apache-maven/lib/maven-model-builder-3.6.2-SNAPSHOT.jar) to field java.io.File.fs, WARNING: Please consider reporting this to the maintainers of org.apache.maven.model.interpolation.StringSearchModelInterpolator$InterpolateObjectAction$CacheField, WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations, WARNING: All illegal access operations will be denied in a future release]>
at org.apache.maven.it.MavenITmng4387QuietLoggingTest.testit(MavenITmng4387QuietLoggingTest.java:71)

Issue Links

• links to: GitHub Pull Request #275