[MNG-6633] ExcludesArtifactFilter is a memory hog

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.6.0
• Fix Version/s: 3.6.2
• Component/s: Core
• Assignee: Sylwester Lachiewicz
• Reporter: Stefan Oehme
• Created: 11/Apr/19 16:16
• Updated: 28/Mar/20 23:16
• Resolved: 25/May/19 14:56

Description

It takes the group and artifact ID of an Exclusion, concatenates them into a new String, which is kept in memory for the whole duration of the build and then compares that String against the concatenation of group and artifact ID of each incoming artifact, adding more CPU cycles than necessary. Instead it should just take the group and artifact ID from the Exclusion object and compare them against the group and artifact ID of the Artifact.

 

For the 2000 module build I'm currently profiling, this is wasting over 1GB of RAM, with hundreds of thousands of duplicated Strings.

 

See https://github.com/apache/maven/pull/243

Issue Links

• links to: GitHub Pull Request #243