Uploaded image for project: 'Maven'
  1. Maven
  2. MNG-6629

DefaultModelValidator.validateId is inefficient

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 3.6.0
    • 3.6.2
    • Core
    • None

    Description

       

      I'm currently optimizing a very large (2000+ submodule) project. DefaultModelValidator.validateId is one of the CPU hotspots, as it uses a regex for validating every ID in the model. Iterating over the characters and checking them against valid ranges would be faster and less memory intensive.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            hboutemy Herve Boutemy
            oehme Stefan Oehme
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment