Uploaded image for project: 'Maven'
  1. Maven
  2. MNG-6575

make Dependency immutable

    XMLWordPrintableJSON

Details

    Description

      while working on Maven memory consumption issue MNG-6571, once VersionRange is made immutable, memory used was divided by 2: the next big expected win is to make Dependency immutable, which would probably once again divide memory by 2 because the vast majority of time, dependencies (be it in dependencyManagement or base dependencies) are inherited without any modification

      this will require to change ModelMerger 's mergeDependency(Dependency target, Dependency source, boolean sourceDominant, Map<Object,Object> context) signature, since is not really an immutable friendly signature
      and also make Dependency code immutable (generated by Modello)

      Attachments

        1. dump-with-mng-6571-fixes.png
          111 kB
          Yann Dameron
        2. dump-with-wrapper-approach.png
          82 kB
          Yann Dameron
        3. MNG-6575-maven-model.patch
          19 kB
          Yann Dameron

        Issue Links

          Activity

            People

              Unassigned Unassigned
              hboutemy Herve Boutemy
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated: