[MNG-6572] use int or long instead of BigIntegers for little numbers in ComparableVersion

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.6.0
• Fix Version/s: 3.6.1
• Component/s: Artifacts and Repositories, Performance
• Labels: up-for-grabs
• Assignee: Herve Boutemy
• Reporter: Herve Boutemy
• Created: 23/Jan/19 16:40
• Updated: 28/Mar/20 15:03
• Resolved: 23/Mar/19 17:38

Description

while working on MNG-6571, we found that this could enhance performance when many versions are compared: perhaps not in Maven builds, since this is probably negligible, but in other scenario where version comparison is used, this could be useful

see https://github.com/apache/maven/blob/master/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java
for every Integer, a BigInteger is currently used
but for integer that have less than 10 digits, an int would be sufficient and would be a lot more efficient
and for integers that are less than 19 digits, a long would be the way to go

the biggest numbers we get usually is the timestamp of a SNAPSHOT, like 20171015.230843 (YYYYMMDD.HHmmss), then an int will be sufficient in the vast majority of case

Issue Links

• causes: MNG-6643 Version comparison CLI does not work anymore
• relates to: MNG-6571 Maven memory consumption issue
• links to: GitHub Pull Request #234