[MNG-6420] ComparableVersion incorrectly parses certain version strings

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 3.5.3, 3.6.3
• Component/s: Core
• Assignee: Unassigned
• Reporter: Ross Goldberg
• Created: 31/May/18 14:17
• Updated: 05/Jan/20 14:40

Description

For certain version strings, ComparableVersion doesn't follow the Maven version order spec (https://maven.apache.org/pom.html#Version_Order_Specification), and/or produces canonical versions that are incongruent with both the spec and the code's ordering.

To improve the code & fix the following bugs, I completely rewrote the version parser (using Java 8). I will create a PR sometime soon.

Bug 1: comparison violates spec ordering
 
java -jar /usr/local/Cellar/maven/3.5.3/libexec/lib/maven-artifact-3.6.3.jar 1-0.3 1
 
Outputs:
 
1. 1-0.3 == 1-0.3
   1-0.3 == 1
2. 1 == 1
 
This problem stems from:
 
https://github.com/apache/maven/blob/b8c06e61ab73cd9e25a5b2c93d9e5077b2196751/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java#L295-L296
 
 
 
Bug 2: canonical incongruent with spec and code ordering
 
java -jar /usr/local/Cellar/maven/3.5.3/libexec/lib/maven-artifact-3.6.3.jar 1-0-2 1-0.1
 
1. 1-0-2 == 1-2
   1-0-2 < 1-0.1
2. 1-0.1 == 1-0.1
 
This problem stems from retaining ListItems that, after normalization, have no children other than the subsequent ListItem.  Removing the unnecessary ListItem should fix this (i.e. remove the extraneous ListItem (named extraneous) from its parent ListItem (named parent), then add the only child of extraneous to parent).

Issue Links

• is related to: MNGSITE-387 semver version strings comparison