Uploaded image for project: 'Maven'
  1. Maven
  2. MNG-6228

Optionality not displayed in dependency tree when run in debug mode

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.5.0
    • Fix Version/s: 3.5.2
    • Component/s: Dependencies, Logging
    • Labels:
      None

      Description

      Consider you have optional dependencies in your POM and run Maven with -X, you'll see:

      [DEBUG] Dependency collection stats: {ConflictMarker.analyzeTime=0, ConflictMarker.markTime=1, ConflictMarker.nodeCount=6, ConflictIdSorter.graphTime=0, ConflictIdSorter.topsortTime=1, ConflictIdSorter.conflictIdCount=5, ConflictIdSorter.conflictIdCycleCount=0, ConflictResolver.totalTime=2, ConflictResolver.conflictItemCount=5, DefaultDependencyCollector.collectTime=26, DefaultDependencyCollector.transformTime=6}
      [DEBUG] org.apache.maven.its.mng5935:test:jar:0.1
      [DEBUG]    com.mysema.querydsl:querydsl-core:jar:3.4.3:compile
      [DEBUG]       com.google.guava:guava:jar:17.0:compile (version managed from 14.0)
      [DEBUG]       com.google.code.findbugs:jsr305:jar:2.0.3:compile (version managed from 1.3.9)
      [DEBUG]       com.mysema.commons:mysema-commons-lang:jar:0.2.4:compile
      [DEBUG]       com.infradna.tool:bridge-method-annotation:jar:1.13:compile
      

      The optional flag is never displayed. This leads to two issues:

      1. It causes confusion with the user
      2. The user thinks that the option flag does not work

      This required information shall be printed as same as MDEP does: ...(optional)

      The expected result would be:

      [DEBUG] Dependency collection stats: {ConflictMarker.analyzeTime=0, ConflictMarker.markTime=1, ConflictMarker.nodeCount=6, ConflictIdSorter.graphTime=0, ConflictIdSorter.topsortTime=1, ConflictIdSorter.conflictIdCount=5, ConflictIdSorter.conflictIdCycleCount=0, ConflictResolver.totalTime=2, ConflictResolver.conflictItemCount=5, DefaultDependencyCollector.collectTime=26, DefaultDependencyCollector.transformTime=6}
      [DEBUG] org.apache.maven.its.mng5935:test:jar:0.1
      [DEBUG]    com.mysema.querydsl:querydsl-core:jar:3.4.3:compile (optional)
      [DEBUG]       com.google.guava:guava:jar:17.0:compile (version managed from 14.0) (optional)
      [DEBUG]       com.google.code.findbugs:jsr305:jar:2.0.3:compile (version managed from 1.3.9) (optional)
      [DEBUG]       com.mysema.commons:mysema-commons-lang:jar:0.2.4:compile (optional)
      [DEBUG]       com.infradna.tool:bridge-method-annotation:jar:1.13:compile (optional)
      

        Issue Links

          Activity

          Hide
          michael-o Michael Osipov added a comment -
          Show
          michael-o Michael Osipov added a comment - Fixed with fd988e78e95a53c3a39ec944869ba62b0c7fc0f0 .
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build maven-3.x #1649 (See https://builds.apache.org/job/maven-3.x/1649/)
          MNG-6228 Optionality not displayed in dependency tree when run in (michaelo: http://git-wip-us.apache.org/repos/asf/?p=maven.git&a=commit&h=fd988e78e95a53c3a39ec944869ba62b0c7fc0f0)

          • (edit) maven-core/src/main/java/org/apache/maven/project/DefaultProjectDependenciesResolver.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build maven-3.x #1649 (See https://builds.apache.org/job/maven-3.x/1649/ ) MNG-6228 Optionality not displayed in dependency tree when run in (michaelo: http://git-wip-us.apache.org/repos/asf/?p=maven.git&a=commit&h=fd988e78e95a53c3a39ec944869ba62b0c7fc0f0 ) (edit) maven-core/src/main/java/org/apache/maven/project/DefaultProjectDependenciesResolver.java

            People

            • Assignee:
              michael-o Michael Osipov
              Reporter:
              michael-o Michael Osipov
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development