Uploaded image for project: 'Maven'
  1. Maven
  2. MNG-6206

We should produce a WARNING by using RELEASE, LATEST as versions

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.5.0
    • Fix Version/s: 3.5.2
    • Component/s: None
    • Labels:
      None

      Description

      Currently we support the usage of LATEST and RELEASE as versions for dependencies. We should encourage users to use real versions or if they really like use version ranges...

      public interface Artifact
          extends Comparable<Artifact>
      {
      
          String RELEASE_VERSION = "RELEASE";
      
          String LATEST_VERSION = "LATEST";
      
      

      https://cwiki.apache.org/confluence/display/MAVEN/Maven+3.x+Compatibility+Notes#Maven3.xCompatibilityNotes-PluginMetaversionResolution

        Issue Links

          Activity

          Hide
          stephenc Stephen Connolly added a comment -

          I see nothing wrong with adding a Warning in 3.5.1

          Show
          stephenc Stephen Connolly added a comment - I see nothing wrong with adding a Warning in 3.5.1
          Hide
          dejan2609 Dejan Stojadinović added a comment -

          I would like to take on this (along with MNG-6207) if that's ok.

          Show
          dejan2609 Dejan Stojadinović added a comment - I would like to take on this (along with MNG-6207 ) if that's ok.
          Hide
          khmarbaise Karl Heinz Marbaise added a comment - - edited

          Sure if you like go for it....But only a single issue which means here only MNG-6206

          Show
          khmarbaise Karl Heinz Marbaise added a comment - - edited Sure if you like go for it....But only a single issue which means here only MNG-6206
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user dejan2609 opened a pull request:

          https://github.com/apache/maven/pull/120

          MNG-6206 display deprecation build warning in case when dependencies use metaversions (LATEST or RELEASE)

          JIRA ticket: [MNG-6206: We should produce a WARNING by using RELEASE, LATEST as versions](https://issues.apache.org/jira/browse/MNG-6206)

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/dejan2609/maven MNG-6206-deprecating-metaversions-for-dependencies

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/maven/pull/120.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #120


          commit b1e934839812ff207b0046a2e6fd4969f08a789c
          Author: dejan2609 <dejan2609@gmail.com>
          Date: 2017-05-20T14:57:55Z

          MNG-6206 display deprecation build warning in case when dependencies use metaversions (LATEST or RELEASE)


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user dejan2609 opened a pull request: https://github.com/apache/maven/pull/120 MNG-6206 display deprecation build warning in case when dependencies use metaversions (LATEST or RELEASE) JIRA ticket: [MNG-6206: We should produce a WARNING by using RELEASE, LATEST as versions] ( https://issues.apache.org/jira/browse/MNG-6206 ) You can merge this pull request into a Git repository by running: $ git pull https://github.com/dejan2609/maven MNG-6206 -deprecating-metaversions-for-dependencies Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven/pull/120.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #120 commit b1e934839812ff207b0046a2e6fd4969f08a789c Author: dejan2609 <dejan2609@gmail.com> Date: 2017-05-20T14:57:55Z MNG-6206 display deprecation build warning in case when dependencies use metaversions (LATEST or RELEASE)
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user dejan2609 commented on the issue:

          https://github.com/apache/maven/pull/120

          My bad, I mistakenly pushed commit without testing; so sorry for that.
          I will close this merge request and create another.

          Show
          githubbot ASF GitHub Bot added a comment - Github user dejan2609 commented on the issue: https://github.com/apache/maven/pull/120 My bad, I mistakenly pushed commit without testing; so sorry for that. I will close this merge request and create another.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user dejan2609 closed the pull request at:

          https://github.com/apache/maven/pull/120

          Show
          githubbot ASF GitHub Bot added a comment - Github user dejan2609 closed the pull request at: https://github.com/apache/maven/pull/120
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user dejan2609 opened a pull request:

          https://github.com/apache/maven/pull/121

          MNG-6206 display deprecation build warning in case when dependencies use metaversions (LATEST or RELEASE)

          *JIRA ticket*: [MNG-6206: We should produce a WARNING by using RELEASE, LATEST as versions](https://issues.apache.org/jira/browse/MNG-6206)

          (Note: replaces previously closed PR #120)

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/dejan2609/maven MNG-6206-deprecating-metaversions-for-dependencies

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/maven/pull/121.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #121


          commit 0f98bbe0c2604aa1a89ab48f2df3861f533b8bbc
          Author: dejan2609 <dejan2609@gmail.com>
          Date: 2017-05-20T14:57:55Z

          MNG-6206 display deprecation build warning in case when dependencies use metaversions (LATEST or RELEASE)


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user dejan2609 opened a pull request: https://github.com/apache/maven/pull/121 MNG-6206 display deprecation build warning in case when dependencies use metaversions (LATEST or RELEASE) * JIRA ticket *: [MNG-6206: We should produce a WARNING by using RELEASE, LATEST as versions] ( https://issues.apache.org/jira/browse/MNG-6206 ) (Note: replaces previously closed PR #120) You can merge this pull request into a Git repository by running: $ git pull https://github.com/dejan2609/maven MNG-6206 -deprecating-metaversions-for-dependencies Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven/pull/121.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #121 commit 0f98bbe0c2604aa1a89ab48f2df3861f533b8bbc Author: dejan2609 <dejan2609@gmail.com> Date: 2017-05-20T14:57:55Z MNG-6206 display deprecation build warning in case when dependencies use metaversions (LATEST or RELEASE)
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user khmarbaise commented on the issue:

          https://github.com/apache/maven/pull/121

          Please make a complete commit message with reference to the appropriate ticket.
          ```
          MNG-6206 display deprecation build warning in case when dependencies use metaversions (LATEST or RELEASE)
          Maybe some explantations/descriptions if needed
          ```
          I have applied your patch on a branch MNG-6206 to check via the integration tests. I have modified the commit message see here:
          https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commitdiff;h=eb6b212b567c287734a2dbbef3c113fe650f1def

          Waiting on the results of the integration tests.

          Show
          githubbot ASF GitHub Bot added a comment - Github user khmarbaise commented on the issue: https://github.com/apache/maven/pull/121 Please make a complete commit message with reference to the appropriate ticket. ``` MNG-6206 display deprecation build warning in case when dependencies use metaversions (LATEST or RELEASE) Maybe some explantations/descriptions if needed ``` I have applied your patch on a branch MNG-6206 to check via the integration tests. I have modified the commit message see here: https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commitdiff;h=eb6b212b567c287734a2dbbef3c113fe650f1def Waiting on the results of the integration tests.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user dejan2609 commented on the issue:

          https://github.com/apache/maven/pull/121

          @khmarbaise
          Integration tests passed as expected, that's nice.

          Commit message is altered just a little bit and force-pushed here.

          Show
          githubbot ASF GitHub Bot added a comment - Github user dejan2609 commented on the issue: https://github.com/apache/maven/pull/121 @khmarbaise Integration tests passed as expected, that's nice. Commit message is altered just a little bit and force-pushed here.
          Hide
          khmarbaise Karl Heinz Marbaise added a comment -

          Hi dejan2609, I have merged the change to Maven master.

          Show
          khmarbaise Karl Heinz Marbaise added a comment - Hi dejan2609, I have merged the change to Maven master.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user khmarbaise commented on the issue:

          https://github.com/apache/maven/pull/121

          I have merged the pull request to Maven master. So you can close the pull request here on GitHub. Thanks for our help.

          Show
          githubbot ASF GitHub Bot added a comment - Github user khmarbaise commented on the issue: https://github.com/apache/maven/pull/121 I have merged the pull request to Maven master. So you can close the pull request here on GitHub. Thanks for our help.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build maven-3.x #1655 (See https://builds.apache.org/job/maven-3.x/1655/)
          MNG-6206 display deprecation build warning in case when dependencies (khmarbaise: http://git-wip-us.apache.org/repos/asf/?p=maven.git&a=commit&h=eb6b212b567c287734a2dbbef3c113fe650f1def)

          • (edit) maven-model-builder/src/main/java/org/apache/maven/model/validation/DefaultModelValidator.java
          • (edit) maven-model-builder/src/test/java/org/apache/maven/model/validation/DefaultModelValidatorTest.java
          • (add) maven-model-builder/src/test/resources/poms/validation/deprecated-dependency-metaversions-latest-and-release.xml
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build maven-3.x #1655 (See https://builds.apache.org/job/maven-3.x/1655/ ) MNG-6206 display deprecation build warning in case when dependencies (khmarbaise: http://git-wip-us.apache.org/repos/asf/?p=maven.git&a=commit&h=eb6b212b567c287734a2dbbef3c113fe650f1def ) (edit) maven-model-builder/src/main/java/org/apache/maven/model/validation/DefaultModelValidator.java (edit) maven-model-builder/src/test/java/org/apache/maven/model/validation/DefaultModelValidatorTest.java (add) maven-model-builder/src/test/resources/poms/validation/deprecated-dependency-metaversions-latest-and-release.xml
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user dejan2609 commented on the issue:

          https://github.com/apache/maven/pull/121

          I'm happy to help !
          Regards.

          Show
          githubbot ASF GitHub Bot added a comment - Github user dejan2609 commented on the issue: https://github.com/apache/maven/pull/121 I'm happy to help ! Regards.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user dejan2609 closed the pull request at:

          https://github.com/apache/maven/pull/121

          Show
          githubbot ASF GitHub Bot added a comment - Github user dejan2609 closed the pull request at: https://github.com/apache/maven/pull/121

            People

            • Assignee:
              khmarbaise Karl Heinz Marbaise
              Reporter:
              khmarbaise Karl Heinz Marbaise
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development