Uploaded image for project: 'Maven'
  1. Maven
  2. MNG-6196

Update slf4j and simplify its color integration

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.5.0-beta-1
    • Fix Version/s: 3.5.2
    • Component/s: Dependencies
    • Labels:
      None

      Description

      Update dependences for maven build

      Slf4j 1.7.22 -> 1.7.25 (SLF4J-394 and SLF4J-395 for SLF4J-389)

      With slf4j update we can simplify maven-slf4j-provider implementation given SLF4J-394

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user khmarbaise commented on the issue:

          https://github.com/apache/maven/pull/109

          Please mention the JIRA issue in your commit message like this:
          ```
          MNG-6196 ...
          ```
          otherwise it's hard to follow changes in history...also updating the JIRA issue title would be a good idea if you have a good idea what is more descriptive...

          Show
          githubbot ASF GitHub Bot added a comment - Github user khmarbaise commented on the issue: https://github.com/apache/maven/pull/109 Please mention the JIRA issue in your commit message like this: ``` MNG-6196  ... ``` otherwise it's hard to follow changes in history...also updating the JIRA issue title would be a good idea if you have a good idea what is more descriptive...
          Hide
          michael-o Michael Osipov added a comment -

          Hervé Boutemy, do you want to upgrade SLF4J now and simplify our provider?

          Show
          michael-o Michael Osipov added a comment - Hervé Boutemy , do you want to upgrade SLF4J now and simplify our provider?
          Hide
          hboutemy Hervé Boutemy added a comment -

          I'd prefer to wait for 3.5.0 release: there is no hurry and I would not appreciate if there is some unexpected change associated to the slf4j update (like System.out cache impact, and so on)

          Show
          hboutemy Hervé Boutemy added a comment - I'd prefer to wait for 3.5.0 release: there is no hurry and I would not appreciate if there is some unexpected change associated to the slf4j update (like System.out cache impact, and so on)
          Hide
          cowwoc Gili added a comment -

          Out of curiosity, what do you mean about logback-classic? I know that Maven ships with slf4j-simpleLogger. Are you planning to replace this with logback?

          Show
          cowwoc Gili added a comment - Out of curiosity, what do you mean about logback-classic? I know that Maven ships with slf4j-simpleLogger. Are you planning to replace this with logback?
          Hide
          michael-o Michael Osipov added a comment -

          We meant nothing and there are no plans.

          Show
          michael-o Michael Osipov added a comment - We meant nothing and there are no plans.
          Hide
          hboutemy Hervé Boutemy added a comment -

          in fact, Maven in its source code is ready for you to switch to multiple logging implementations, even if by default slf4j-simple is used and we don't expect to change

          This issues mixes 3 dependencies whose status is really not of the same nature:

          • slf4j, which is used as api and simple implementation as default
          • Mockito, which is a testing dependency: normal users don't care
          • logback, which is just ready for advanced users to switch

          The important change in this issue is for sure slf4j-api and slaf4j-simple
          Others are just notified, while at it, but IMHO just make noise

          Show
          hboutemy Hervé Boutemy added a comment - in fact, Maven in its source code is ready for you to switch to multiple logging implementations, even if by default slf4j-simple is used and we don't expect to change This issues mixes 3 dependencies whose status is really not of the same nature: slf4j, which is used as api and simple implementation as default Mockito, which is a testing dependency: normal users don't care logback, which is just ready for advanced users to switch The important change in this issue is for sure slf4j-api and slaf4j-simple Others are just notified, while at it, but IMHO just make noise
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hboutemy commented on the issue:

          https://github.com/apache/maven/pull/118

          great, I'll merge your ideas with https://github.com/apache/maven/commit/75b23eb01f913cf90d6ac4f9d2d5d7f6b9d69e1a : removing the patching part will be a be a good benefit

          issue tracked in https://issues.apache.org/jira/browse/MNG-6196

          Show
          githubbot ASF GitHub Bot added a comment - Github user hboutemy commented on the issue: https://github.com/apache/maven/pull/118 great, I'll merge your ideas with https://github.com/apache/maven/commit/75b23eb01f913cf90d6ac4f9d2d5d7f6b9d69e1a : removing the patching part will be a be a good benefit issue tracked in https://issues.apache.org/jira/browse/MNG-6196
          Show
          hboutemy Hervé Boutemy added a comment - branch available: https://github.com/apache/maven/commits/MNG-6196_slf4j
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hboutemy commented on the issue:

          https://github.com/apache/maven/pull/118

          ideas added to the MNG-6196 branch in https://github.com/apache/maven/commit/c2a8787eb7450cb28d7f08698788c5e58a3f8a02 : no monkey patch any more
          I kept dependency:unpack+build-helper:add-source instead of switching to shade because I prefer the resulting source jar

          Show
          githubbot ASF GitHub Bot added a comment - Github user hboutemy commented on the issue: https://github.com/apache/maven/pull/118 ideas added to the MNG-6196 branch in https://github.com/apache/maven/commit/c2a8787eb7450cb28d7f08698788c5e58a3f8a02 : no monkey patch any more I kept dependency:unpack+build-helper:add-source instead of switching to shade because I prefer the resulting source jar
          Hide
          hboutemy Hervé Boutemy added a comment -

          removed the logback-classic and mockito changes, which are really so much separate issues: slf4j upgrade is really something that requires specific attention

          don't hesitate to create another issue for logback classic and mockito

          Show
          hboutemy Hervé Boutemy added a comment - removed the logback-classic and mockito changes, which are really so much separate issues: slf4j upgrade is really something that requires specific attention don't hesitate to create another issue for logback classic and mockito
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build maven-3.x #1671 (See https://builds.apache.org/job/maven-3.x/1671/)
          MNG-6196 updated slf4j to 1.7.25 (hboutemy: http://git-wip-us.apache.org/repos/asf/?p=maven.git&a=commit&h=eb2db7b28664dbaac6a59a2189c70d92e455dcea)

          • (edit) apache-maven/src/conf/logging/simplelogger.properties
          • (edit) maven-slf4j-provider/src/main/java/org/slf4j/impl/MavenSimpleLogger.java
          • (edit) pom.xml
          • (edit) maven-slf4j-provider/src/main/script/patch-slf4j-simple.groovy
            MNG-6196 removed remaining Monkey patching, not really necessary (hboutemy: http://git-wip-us.apache.org/repos/asf/?p=maven.git&a=commit&h=4f530c4f006b8d22da90d968a1d32797280804b9)
          • (add) maven-slf4j-provider/src/main/java/org/slf4j/impl/StaticLoggerBinder.java
          • (delete) maven-slf4j-provider/src/main/script/patch-slf4j-simple.groovy
          • (edit) maven-slf4j-provider/pom.xml
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build maven-3.x #1671 (See https://builds.apache.org/job/maven-3.x/1671/ ) MNG-6196 updated slf4j to 1.7.25 (hboutemy: http://git-wip-us.apache.org/repos/asf/?p=maven.git&a=commit&h=eb2db7b28664dbaac6a59a2189c70d92e455dcea ) (edit) apache-maven/src/conf/logging/simplelogger.properties (edit) maven-slf4j-provider/src/main/java/org/slf4j/impl/MavenSimpleLogger.java (edit) pom.xml (edit) maven-slf4j-provider/src/main/script/patch-slf4j-simple.groovy MNG-6196 removed remaining Monkey patching, not really necessary (hboutemy: http://git-wip-us.apache.org/repos/asf/?p=maven.git&a=commit&h=4f530c4f006b8d22da90d968a1d32797280804b9 ) (add) maven-slf4j-provider/src/main/java/org/slf4j/impl/StaticLoggerBinder.java (delete) maven-slf4j-provider/src/main/script/patch-slf4j-simple.groovy (edit) maven-slf4j-provider/pom.xml
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user slachiewicz commented on the issue:

          https://github.com/apache/maven/pull/109

          ok, MNG-6196 with slf4j was merged to master - i'm clossing this issue. Mockito will be in diffrent pull.

          Show
          githubbot ASF GitHub Bot added a comment - Github user slachiewicz commented on the issue: https://github.com/apache/maven/pull/109 ok, MNG-6196 with slf4j was merged to master - i'm clossing this issue. Mockito will be in diffrent pull.

            People

            • Assignee:
              hboutemy Hervé Boutemy
              Reporter:
              slachiewicz Sylwester Lachiewicz
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development