Uploaded image for project: 'Maven'
  1. Maven
  2. MNG-6195

Use consistent quoting forms in mvn launcher script

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.5.0-alpha-1, 3.5.0-beta-1
    • Fix Version/s: 3.5.0
    • Component/s: core
    • Labels:
      None

      Description

      We have different forms of quoting in the shell script. We should pick a consistent policy and follow that.

      Specific areas of concern around backticks and $(...)

      Solaris 10 is known to have a true BourneShell which does not understand $(...) but the backtick style is very hard to quote effectively

        Issue Links

          Activity

          Hide
          stephenc Stephen Connolly added a comment -

          So FreeBSD also ships with a BourneShell for non-root users so in FreeBSD

          $ echo "$(ls)"
          Illegal variable name.
          $ echo "`ls`"
          .cshrc .k5login .login .profile
          
          Show
          stephenc Stephen Connolly added a comment - So FreeBSD also ships with a BourneShell for non-root users so in FreeBSD $ echo "$(ls)" Illegal variable name. $ echo "`ls`" .cshrc .k5login .login .profile
          Hide
          michael-o Michael Osipov added a comment -

          I would get rid of backquotes in 4.0. Solaris 10 is supported by Oracle for several years, but it remains broken.
          FreeBSD works, you have tested in csh.

          Test:

          $ finger mosipov
          Login: mosipov                          Name: Michael Osipov
          Directory: /home/mosipov                Shell: /bin/sh
          $ echo "$(ls)"
          Projekte
          apache-maven-3.5.0-SNAPSHOT
          apache-maven-3.5.0-SNAPSHOT-bin.tar.gz
          mtime-test.jar
          
          Show
          michael-o Michael Osipov added a comment - I would get rid of backquotes in 4.0. Solaris 10 is supported by Oracle for several years, but it remains broken. FreeBSD works, you have tested in csh . Test: $ finger mosipov Login: mosipov Name: Michael Osipov Directory: /home/mosipov Shell: /bin/sh $ echo "$(ls)" Projekte apache-maven-3.5.0-SNAPSHOT apache-maven-3.5.0-SNAPSHOT-bin.tar.gz mtime-test.jar
          Hide
          stephenc Stephen Connolly added a comment -

          87cf1eeb7d2506e192da77f7d5b286fae2b20314

          Show
          stephenc Stephen Connolly added a comment - 87cf1eeb7d2506e192da77f7d5b286fae2b20314
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build maven-3.x #1587 (See https://builds.apache.org/job/maven-3.x/1587/)
          MNG-6195 Tidy up quoting and command substitution (stephen.alan.connolly: http://git-wip-us.apache.org/repos/asf/?p=maven.git&a=commit&h=96543b7c6ea52ad7ba3bcd559c38b159f8aa4c0d)

          • (edit) apache-maven/src/bin/mvn
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build maven-3.x #1587 (See https://builds.apache.org/job/maven-3.x/1587/ ) MNG-6195 Tidy up quoting and command substitution (stephen.alan.connolly: http://git-wip-us.apache.org/repos/asf/?p=maven.git&a=commit&h=96543b7c6ea52ad7ba3bcd559c38b159f8aa4c0d ) (edit) apache-maven/src/bin/mvn

            People

            • Assignee:
              stephenc Stephen Connolly
              Reporter:
              stephenc Stephen Connolly
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development