Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.5.0-beta-1
    • Fix Version/s: 3.5.2
    • Labels:
      None

      Description

      calculating the directory where jansi native lib is available required a hack = copy/paste HawtJNI code https://git1-us-west.apache.org/repos/asf?p=maven.git;a=blobdiff;f=maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java;h=350fa61c5da633a04fa17c1ed7530096c4ad60ad;hp=b3367c177c91fae32831207ab4a568121da621f0;hb=181b0215aa1199e152db9d2c08b1a01436547805;hpb=809ba34055c70eab31876aad03c577e925fa2e6e

      This should become a HawtJNI feature (ie. library.jansi.path should point to lib/jansi-native and HawtJNI should find the right directory the same way it does it in classpath), then we'll be able to integrate it instead of hacking

        Issue Links

          Activity

          Hide
          hboutemy Hervé Boutemy added a comment -

          https://github.com/fusesource/hawtjni/pull/35 created
          with this enhancement to HawtJNI, we can set library.jansi.path=$maven.home/lib/jansi-native basically in the shell script and Jansi/HawtJNI will find $maven.home/lib/jansi-native/$platform/$library (no need to copy paste algorithm in Maven to compute $maven.home/lib/jansi-native/$platform directory name)

          Show
          hboutemy Hervé Boutemy added a comment - https://github.com/fusesource/hawtjni/pull/35 created with this enhancement to HawtJNI, we can set library.jansi.path=$maven.home/lib/jansi-native basically in the shell script and Jansi/HawtJNI will find $maven.home/lib/jansi-native/$platform/$library (no need to copy paste algorithm in Maven to compute $maven.home/lib/jansi-native/$platform directory name)
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build maven-3.x #1648 (See https://builds.apache.org/job/maven-3.x/1648/)
          MNG-6186 use enhanced HawtJNI library loading (remove previous hack) (hboutemy: http://git-wip-us.apache.org/repos/asf/?p=maven.git&a=commit&h=6182a2083fdb9964ccb5250fb85223e38485bf04)

          • (edit) apache-maven/src/bin/mvn.cmd
          • (edit) maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
          • (edit) apache-maven/src/bin/mvn
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build maven-3.x #1648 (See https://builds.apache.org/job/maven-3.x/1648/ ) MNG-6186 use enhanced HawtJNI library loading (remove previous hack) (hboutemy: http://git-wip-us.apache.org/repos/asf/?p=maven.git&a=commit&h=6182a2083fdb9964ccb5250fb85223e38485bf04 ) (edit) apache-maven/src/bin/mvn.cmd (edit) maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java (edit) apache-maven/src/bin/mvn
          Hide
          hboutemy Hervé Boutemy added a comment -

          cleanup done after JAnsi 1.16 upgrade, which upgrade HawtJNI to 1.15

          Show
          hboutemy Hervé Boutemy added a comment - cleanup done after JAnsi 1.16 upgrade, which upgrade HawtJNI to 1.15
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build maven-3.x #1656 (See https://builds.apache.org/job/maven-3.x/1656/)
          MNG-6186 fixed path to jansi native libs in distribution (hboutemy: http://git-wip-us.apache.org/repos/asf/?p=maven.git&a=commit&h=707cff6ffdecbfb0e0356c70e3a7b490535e7ce4)

          • (edit) apache-maven/src/bin/mvn.cmd
          • (edit) apache-maven/src/bin/mvn
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build maven-3.x #1656 (See https://builds.apache.org/job/maven-3.x/1656/ ) MNG-6186 fixed path to jansi native libs in distribution (hboutemy: http://git-wip-us.apache.org/repos/asf/?p=maven.git&a=commit&h=707cff6ffdecbfb0e0356c70e3a7b490535e7ce4 ) (edit) apache-maven/src/bin/mvn.cmd (edit) apache-maven/src/bin/mvn

            People

            • Assignee:
              hboutemy Hervé Boutemy
              Reporter:
              hboutemy Hervé Boutemy
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development