Uploaded image for project: 'Maven'
  1. Maven
  2. MNG-6172

Precedence of command-line system property options has changed

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.5.0-alpha-1, 3.5.0
    • Component/s: Command Line
    • Labels:
      None

      Description

      The current state of master (what will eventually become 3.5.0) has reversed the precedence of command-line system property options compared to previous releases of Maven.

      For example, running this command with a basic project:

      mvn -Dmaven.repo.local=/tmp/aaa -Dmaven.repo.local=/tmp/zzz validate
      

      using current master will cause /tmp/aaa to be created (first-one-wins), whereas for all previous releases of Maven /tmp/zzz would have been created (last-one-wins)

      This has the potential to break CI builds which relied on the previous last-one-wins behaviour.

      This was introduced by the fix for MNG-6078 https://github.com/apache/maven/commit/ca4303031357a7decaee8de770b71fb2c2fedd28 - by reversing the whole array the precedence between options on the same command line has been reversed, not just the relationship between .mvn/maven.config options and command line options.

        Activity

        Hide
        michael-o Michael Osipov added a comment -

        Do we need to drop this commit or rework?

        Show
        michael-o Michael Osipov added a comment - Do we need to drop this commit or rework?
        Hide
        stephenc Stephen Connolly added a comment -

        I think we need to fix this. This would catch me out

        Show
        stephenc Stephen Connolly added a comment - I think we need to fix this. This would catch me out
        Hide
        stephenc Stephen Connolly added a comment -

        Fixed with dc9c4db4494b62e2231bb67b39678decf6329852 in maven-core

        Show
        stephenc Stephen Connolly added a comment - Fixed with dc9c4db4494b62e2231bb67b39678decf6329852 in maven-core

          People

          • Assignee:
            stephenc Stephen Connolly
            Reporter:
            mcculls Stuart McCulloch
          • Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development