Details
-
Type:
Improvement
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 3.3.9
-
Fix Version/s: 3.5.0-alpha-1, 3.5.0
-
Component/s: None
-
Labels:None
Description
The following can easily be squashed:
d99f9ef8c7ffe56966945d6f1b66f0280866ded5 Fix checkstyle error 1c9362be4328713386bd23b01f9e2c87674cb952 Use static final values instead of literals 52945a679ec8f3f571d77658eda2fce06d637aa7 Use proper spelling of "e.g." a26cc1b9636e19c28cd32ed1c844fec64dec55b6 Use the proper term for char U+002D (-) hyphen(-minus) instead of dash
Issue Links
- links to
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/100
Can you rebase your changes and squash into one commit? I want to pull them in with MNG-6146(https://issues.apache.org/jira/browse/MNG-6146?src=confmacro).
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/100
Testing your changes now: https://builds.apache.org/job/maven-3.x-jenkinsfile/job/MNG-6146/
FAILURE: Integrated in Jenkins build maven-3.x #1538 (See https://builds.apache.org/job/maven-3.x/1538/)
MNG-6146 Several small stylistic and spelling improvements to code and (michaelo: http://git-wip-us.apache.org/repos/asf/?p=maven.git&a=commit&h=17402659845ea21b0dd9f9989d484fb32c3aa28b)
- (add) maven-core/src/test/resources-project-builder/plugin-exec-config-order/w-plugin-mgmt/pom.xml
- (add) maven-core/src/test/resources-project-builder/merged-plugin-class-path-order/w-plugin-mgmt/sub/pom.xml
- (add) maven-core/src/test/resources-project-builder/dependency-order/w-plugin-mgmt/pom.xml
- (delete) maven-core/src/test/resources-project-builder/merged-plugin-exec-goals-order/w-plugin-mngt/sub/pom.xml
- (edit) maven-model-builder/src/main/java/org/apache/maven/model/building/ModelBuildingRequest.java
- (edit) maven-core/src/test/java/org/apache/maven/project/DefaultMavenProjectBuilderTest.java
- (edit) maven-core/src/site/apt/offline-mode.apt
- (edit) maven-core/src/test/resources-project-builder/repo-inheritance/pom.xml
- (delete) maven-core/src/test/resources-project-builder/plugin-exec-goals-order/wo-plugin-mngt/pom.xml
- (edit) maven-compat/src/test/java/org/apache/maven/project/inheritance/t05/ProjectInheritanceTest.java
- (edit) maven-compat/src/test/java/org/apache/maven/project/inheritance/t10/ProjectInheritanceTest.java
- (delete) maven-core/src/test/resources-project-builder/plugin-config-order/wo-plugin-mngt/pom.xml
- (edit) maven-model/src/main/mdo/maven.mdo
- (delete) maven-core/src/test/resources-project-builder/merged-plugin-class-path-order/w-plugin-mngt/sub/pom.xml
- (edit) maven-core/src/main/java/org/apache/maven/plugin/ExtensionRealmCache.java
- (edit) maven-core/src/test/java/org/apache/maven/lifecycle/internal/stub/AboutTheStubs.html
- (edit) maven-compat/src/test/java/org/apache/maven/project/inheritance/t06/ProjectInheritanceTest.java
- (edit) maven-embedder/src/test/error-reporting-projects/mojo-lookup-err/plugin/src/main/java/org/plugin/TestPlugin.java
- (edit) maven-settings/src/main/mdo/settings.mdo
- (delete) maven-core/src/test/resources-project-builder/plugin-exec-config-order/wo-plugin-mngt/pom.xml
- (delete) maven-core/src/test/resources-project-builder/plugin-exec-order/wo-plugin-mngt/pom.xml
- (edit) maven-compat/src/main/java/org/apache/maven/repository/legacy/resolver/DefaultLegacyArtifactCollector.java
- (edit) maven-compat/src/main/java/org/apache/maven/project/inheritance/ModelInheritanceAssembler.java
- (edit) maven-compat/src/test/java/org/apache/maven/project/inheritance/t12scm/ProjectInheritanceTest.java
- (edit) maven-embedder/src/test/embedder-test-project/src/test/java/org/apache/maven/AppTest.java
- (edit) maven-embedder/src/examples/simple-project/src/test/java/org/apache/maven/embedder/AppTest.java
- (edit) maven-core/src/main/mdo/toolchains.mdo
- (delete) maven-core/src/test/resources-project-builder/sytem-property-interpolation/pom.xml
- (delete) maven-core/src/test/resources-project-builder/merged-plugin-exec-goals-order/wo-plugin-mngt/pom.xml
- (edit) maven-core/src/test/java/org/apache/maven/project/PomConstructionTest.java
- (edit) maven-plugin-api/src/main/mdo/lifecycle.mdo
- (edit) maven-core/src/main/java/org/apache/maven/lifecycle/internal/builder/multithreaded/ThreadOutputMuxer.java
- (edit) maven-core/src/test/java/org/apache/maven/graph/DefaultProjectDependencyGraphTest.java
- (delete) maven-core/src/test/resources-project-builder/unique-dependency-key/dep-mngt-in-profile/pom.xml
- (edit) maven-core/src/test/java/org/apache/maven/lifecycle/internal/stub/ProjectDependencyGraphStub.java
- (edit) maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/DefaultArtifactDescriptorReader.java
- (edit) maven-core/src/site/apt/plugin-execution-isolation.apt
- (add) maven-core/src/test/resources-project-builder/plugin-config-attributes/w-plugin-mgmt/pom.xml
- (delete) maven-core/src/test/resources-project-builder/unique-dependency-key/dep-mngt/pom.xml
- (edit) maven-core/src/main/java/org/apache/maven/project/DefaultProjectBuildingHelper.java
- (delete) maven-core/src/test/resources-project-builder/plugin-exec-w-and-wo-id/w-plugin-mngt/pom.xml
- (edit) maven-core/src/test/java/org/apache/maven/project/EmptyProjectBuildingHelper.java
- (edit) maven-core/src/test/resources-project-builder/prerequisites-inheritance/child/pom.xml
- (edit) maven-core/lifecycle-executor.txt
- (edit) maven-core/src/main/java/org/apache/maven/plugin/version/PluginVersionRequest.java
- (edit) maven-compat/src/test/java/org/apache/maven/project/inheritance/t09/ProjectInheritanceTest.java
- (edit) maven-core/src/main/java/org/apache/maven/project/DefaultProjectDependenciesResolver.java
- (delete) maven-core/src/test/resources-project-builder/merged-plugin-class-path-order/wo-plugin-mngt/pom.xml
- (edit) maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
- (edit) maven-core/src/test/projects/lifecycle-executor/project-with-additional-lifecycle-elements/src/test/java/org/apache/maven/lifecycle/test/AppTest.java
- (add) maven-core/src/test/resources-project-builder/plugin-exec-merging/w-plugin-mgmt/pom.xml
- (delete) maven-core/src/test/resources-project-builder/dependency-order/wo-plugin-mngt/pom.xml
- (edit) maven-core/src/main/java/org/apache/maven/lifecycle/internal/GoalTask.java
- (edit) maven-embedder/src/test/error-reporting-projects/err-resolving-project-dep/project/src/test/java/org/apache/maven/test/error/mojoFailure/AppTest.java
- (add) maven-core/src/test/resources-project-builder/plugin-exec-merging/wo-plugin-mgmt/sub/pom.xml
- (edit) maven-core/src/test/java/org/apache/maven/lifecycle/LifecycleExecutorSubModulesTest.java
- (edit) maven-core/src/test/java/org/apache/maven/plugin/PluginManagerTest.java
- (add) maven-core/src/test/resources-project-builder/plugin-exec-order/wo-plugin-mgmt/pom.xml
- (edit) maven-core/src/test/resources-project-builder/plugin-inheritance-order/pom.xml
- (edit) maven-compat/src/test/java/org/apache/maven/project/inheritance/t07/ProjectInheritanceTest.java
- (edit) maven-compat/pom.xml
- (edit) maven-compat/src/main/mdo/profiles.mdo
- (edit) maven-artifact/src/main/java/org/apache/maven/artifact/versioning/DefaultArtifactVersion.java
- (edit) maven-core/src/main/java/org/apache/maven/project/ProjectBuildingRequest.java
- (edit) maven-compat/src/test/java/org/apache/maven/project/inheritance/t00/ProjectInheritanceTest.java
- (delete) maven-core/src/test/resources-project-builder/merged-plugin-exec-order/wo-plugin-mngt/pom.xml
- (edit) maven-core/src/main/java/org/apache/maven/eventspy/EventSpy.java
- (add) maven-core/src/test/resources-project-builder/plugin-exec-w-and-wo-id/wo-plugin-mgmt/pom.xml
- (edit) maven-model-builder/src/main/java/org/apache/maven/model/inheritance/DefaultInheritanceAssembler.java
- (add) maven-core/src/test/resources-project-builder/merged-plugin-exec-goals-order/wo-plugin-mgmt/sub/pom.xml
- (delete) maven-core/src/test/resources-project-builder/merged-plugin-exec-order/w-plugin-mngt/pom.xml
- (edit) maven-compat/src/test/java/org/apache/maven/project/inheritance/t03/ProjectInheritanceTest.java
- (add) maven-core/src/test/resources-project-builder/merged-plugin-exec-order/wo-plugin-mgmt/pom.xml
- (edit) apache-maven/README.txt
- (edit) maven-compat/src/main/java/org/apache/maven/artifact/installer/ArtifactInstaller.java
- (delete) maven-core/src/test/resources-project-builder/merged-plugin-exec-order/w-plugin-mngt/sub/pom.xml
- (edit) maven-compat/src/main/java/org/apache/maven/artifact/resolver/ResolutionListenerForDepMgmt.java
- (edit) maven-core/src/main/java/org/apache/maven/project/MavenProjectHelper.java
- (edit) maven-core/src/site/apt/configuration-management.apt
- (edit) maven-core/src/main/java/org/apache/maven/project/artifact/ProjectArtifact.java
- (edit) maven-embedder/src/test/error-reporting-projects/project-mojo-failure/src/test/java/org/apache/maven/test/error/mojoFailure/AppTest.java
- (edit) maven-core/src/main/java/org/apache/maven/project/artifact/MavenMetadataSource.java
- (delete) maven-core/src/test/resources-project-builder/merged-plugin-exec-goals-order/wo-plugin-mngt/sub/pom.xml
- (delete) maven-core/src/test/resources-project-builder/plugin-config-attributes/w-plugin-mngt/pom.xml
- (add) maven-core/src/test/resources-project-builder/plugin-exec-merging/wo-plugin-mgmt/pom.xml
- (edit) maven-embedder/src/test/projects/isolated-project-getting-parent-pom/project/src/test/java/org/codehaus/m2eclipse/AppTest.java
- (edit) maven-core/src/main/java/org/apache/maven/internal/aether/DefaultRepositorySystemSessionFactory.java
- (edit) maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/ArtifactDescriptorReaderDelegate.java
- (edit) maven-core/src/main/java/org/apache/maven/artifact/resolver/ArtifactResolutionResult.java
- (edit) maven-core/src/test/java/org/apache/maven/project/ProjectSorterTest.java
- (edit) maven-core/src/test/java/org/apache/maven/toolchain/merge/MavenToolchainMergerTest.java
- (edit) maven-compat/src/main/java/org/apache/maven/repository/metadata/MetadataGraphVertex.java
- (edit) maven-core/src/test/resources-project-builder/xml-coalesce-text/pom.xml
- (add) maven-core/src/test/resources-project-builder/merged-plugin-class-path-order/wo-plugin-mgmt/sub/pom.xml
- (edit) maven-embedder/src/test/error-reporting-projects/project-dep-missing/src/test/java/org/apache/maven/test/error/mojoFailure/AppTest.java
- (edit) maven-model-builder/src/test/java/org/apache/maven/model/inheritance/DefaultInheritanceAssemblerTest.java
- (add) maven-core/src/test/resources-project-builder/merged-plugin-exec-order/w-plugin-mgmt/sub/pom.xml
- (add) maven-core/src/test/resources-project-builder/merged-plugin-exec-goals-order/wo-plugin-mgmt/pom.xml
- (add) maven-core/src/test/resources-project-builder/unique-dependency-key/dep-mgmt-in-profile/pom.xml
- (add) maven-core/src/test/resources-project-builder/unique-dependency-key/dep-mgmt/pom.xml
- (edit) maven-core/src/test/java/org/apache/maven/plugin/internal/DefaultLegacySupportTest.java
- (delete) maven-core/src/test/resources-project-builder/merged-plugin-exec-goals-order/w-plugin-mngt/pom.xml
- (delete) maven-core/src/test/resources-project-builder/dependency-order/w-plugin-mngt/pom.xml
- (delete) maven-core/src/test/resources-project-builder/merged-plugin-class-path-order/w-plugin-mngt/pom.xml
- (delete) maven-core/src/test/resources-project-builder/merged-plugin-exec-order/wo-plugin-mngt/sub/pom.xml
- (edit) maven-core/src/test/resources-project-builder/pom-inheritance/sub/pom.xml
- (edit) maven-model-builder/src/main/java/org/apache/maven/model/composition/DefaultDependencyManagementImporter.java
- (edit) maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java
- (edit) maven-resolver-provider/src/test/java/org/apache/maven/repository/internal/RepositorySystemTest.java
- (edit) maven-model-builder/src/main/java/org/apache/maven/model/validation/DefaultModelValidator.java
- (add) maven-core/src/test/resources-project-builder/merged-plugin-exec-order/w-plugin-mgmt/pom.xml
- (delete) maven-core/src/test/resources-project-builder/plugin-exec-goals-order/w-plugin-mngt/pom.xml
- (edit) maven-compat/src/test/java/org/apache/maven/project/inheritance/t01/ProjectInheritanceTest.java
- (add) maven-core/src/test/resources-project-builder/plugin-config-attributes/wo-plugin-mgmt/pom.xml
- (add) maven-core/src/test/resources-project-builder/plugin-exec-goals-order/w-plugin-mgmt/pom.xml
- (delete) maven-core/src/test/resources-project-builder/plugin-exec-merging/w-plugin-mngt/sub/pom.xml
- (edit) maven-model-builder/src/main/mdo/profiles.mdo
- (add) maven-core/src/test/resources-project-builder/merged-plugin-exec-order/wo-plugin-mgmt/sub/pom.xml
- (add) maven-core/src/test/resources-project-builder/merged-plugin-class-path-order/w-plugin-mgmt/pom.xml
- (delete) maven-core/src/test/resources-project-builder/plugin-exec-w-and-wo-id/wo-plugin-mngt/pom.xml
- (add) maven-core/src/test/resources-project-builder/plugin-exec-order/w-plugin-mgmt/pom.xml
- (edit) maven-compat/src/test/java/org/apache/maven/project/inheritance/t11/ProjectInheritanceTest.java
- (edit) maven-compat/src/main/java/org/apache/maven/project/inheritance/DefaultModelInheritanceAssembler.java
- (edit) maven-compat/src/test/java/org/apache/maven/project/inheritance/t08/ProjectInheritanceTest.java
- (delete) maven-core/src/test/resources-project-builder/plugin-exec-merging/wo-plugin-mngt/sub/pom.xml
- (edit) maven-core/src/main/java/org/apache/maven/artifact/repository/MavenArtifactRepository.java
- (edit) maven-compat/src/test/java/org/apache/maven/project/inheritance/t02/ProjectInheritanceTest.java
- (edit) maven-core/src/main/java/org/apache/maven/project/DefaultProjectBuildingResult.java
- (edit) maven-core/plugin-manager.txt
- (delete) maven-core/src/test/resources-project-builder/merged-plugin-class-path-order/wo-plugin-mngt/sub/pom.xml
- (add) maven-core/src/test/resources-project-builder/dependency-order/wo-plugin-mgmt/pom.xml
- (delete) maven-core/src/test/resources-project-builder/plugin-exec-merging/w-plugin-mngt/pom.xml
- (delete) maven-core/src/test/resources-project-builder/plugin-config-attributes/wo-plugin-mngt/pom.xml
- (edit) maven-repository-metadata/src/site/apt/index.apt
- (edit) maven-compat/src/test/java/org/apache/maven/project/inheritance/t04/ProjectInheritanceTest.java
- (delete) maven-core/src/test/resources-project-builder/plugin-exec-order/w-plugin-mngt/pom.xml
- (delete) maven-core/src/test/resources-project-builder/plugin-exec-config-order/w-plugin-mngt/pom.xml
- (edit) maven-core/src/main/java/org/apache/maven/lifecycle/internal/TaskSegment.java
- (edit) maven-core/src/main/java/org/apache/maven/plugin/DebugConfigurationListener.java
- (edit) maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java
- (add) maven-core/src/test/resources-project-builder/plugin-exec-config-order/wo-plugin-mgmt/pom.xml
- (edit) maven-core/src/main/java/org/apache/maven/configuration/DefaultBeanConfigurationRequest.java
- (add) maven-core/src/test/resources-project-builder/plugin-config-order/w-plugin-mgmt/pom.xml
- (add) maven-core/src/test/resources-project-builder/plugin-exec-merging/w-plugin-mgmt/sub/pom.xml
- (add) maven-core/src/test/resources-project-builder/plugin-exec-w-and-wo-id/w-plugin-mgmt/pom.xml
- (edit) maven-core/src/test/resources/org/apache/maven/extension/test-extension-repo/org/apache/maven/maven-parent/5/maven-parent-5.pom
- (edit) maven-core/src/main/java/org/apache/maven/repository/legacy/metadata/MetadataResolutionRequest.java
- (edit) maven-embedder/src/test/error-reporting-projects/missing-module-pom/child1/src/test/java/org/test/AppTest.java
- (edit) maven-compat/src/main/java/org/apache/maven/profiles/DefaultProfileManager.java
- (edit) maven-model-builder/src/main/java/org/apache/maven/model/building/ModelBuildingListener.java
- (add) maven-core/src/test/resources-project-builder/plugin-exec-goals-order/wo-plugin-mgmt/pom.xml
- (delete) maven-core/src/test/resources-project-builder/plugin-exec-merging/wo-plugin-mngt/pom.xml
- (add) maven-core/src/test/resources-project-builder/merged-plugin-exec-goals-order/w-plugin-mgmt/pom.xml
- (add) maven-core/src/test/resources-project-builder/merged-plugin-exec-goals-order/w-plugin-mgmt/sub/pom.xml
- (edit) maven-artifact/src/main/java/org/apache/maven/artifact/resolver/CyclicDependencyException.java
- (edit) maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/MojoDescriptor.java
- (add) maven-core/src/test/resources-project-builder/plugin-config-order/wo-plugin-mgmt/pom.xml
- (add) maven-core/src/test/resources-project-builder/merged-plugin-class-path-order/wo-plugin-mgmt/pom.xml
- (add) maven-core/src/test/resources-project-builder/system-property-interpolation/pom.xml
- (delete) maven-core/src/test/resources-project-builder/plugin-config-order/w-plugin-mngt/pom.xml
IT commit too c09aaa3554b0b67ebedabbfc7821c55d1aecb1da.