Uploaded image for project: 'Maven'
  1. Maven
  2. MNG-6106

Remove maven.home default value setter from m2.conf

    Details

      Description

      The set maven.home default ${user.home}/m2 seems to be a relic from ancient times: maven.home property is always defined by mvn launch script
      Even if it would be used, it wouldn't work because user.home never contains Maven's installation files.
      This line can safely be removed.

        Issue Links

          Activity

          Hide
          michael-o Michael Osipov added a comment -
          Show
          michael-o Michael Osipov added a comment - Fixed with f7c1359cf4e3ed82b91b78688076ff684a4eb9a8 .
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build maven-3.x #1397 (See https://builds.apache.org/job/maven-3.x/1397/)
          MNG-6106 Remove maven.home setter from m2.conf (michaelo: rev f7c1359cf4e3ed82b91b78688076ff684a4eb9a8)

          • (edit) apache-maven/src/bin/m2.conf
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build maven-3.x #1397 (See https://builds.apache.org/job/maven-3.x/1397/ ) MNG-6106 Remove maven.home setter from m2.conf (michaelo: rev f7c1359cf4e3ed82b91b78688076ff684a4eb9a8) (edit) apache-maven/src/bin/m2.conf
          Hide
          hboutemy Hervé Boutemy added a comment - - edited

          IIUC your comment on dev list: "This is actually a bug because maven.home can never be user.home/.m2"
          default value is not user.home/.m2 but user.home/m2: typo on dev list, or overlooked .m2 vs m2 during hard review?

          Show
          hboutemy Hervé Boutemy added a comment - - edited IIUC your comment on dev list: "This is actually a bug because maven.home can never be user.home/.m2" default value is not user.home/.m2 but user.home/m2 : typo on dev list, or overlooked .m2 vs m2 during hard review?
          Hide
          michael-o Michael Osipov added a comment -

          You are right, the dot (.) slipped through my eyes. Still, none of them can be a valid Maven home. Thanks for raising.

          Show
          michael-o Michael Osipov added a comment - You are right, the dot ( . ) slipped through my eyes. Still, none of them can be a valid Maven home. Thanks for raising.
          Hide
          hboutemy Hervé Boutemy added a comment -

          why can't user.home/m2 be a valid Maven home? I don't get the reasoning

          Show
          hboutemy Hervé Boutemy added a comment - why can't user.home/m2 be a valid Maven home? I don't get the reasoning
          Hide
          michael-o Michael Osipov added a comment -

          We never had this in use, never promoted. Additionally, people might confuse it with ${user.home}/.m2 and it does not work because it is always set in wrapper script, Plexus conf sets in case of absence. You cannot use it anyway.

          Show
          michael-o Michael Osipov added a comment - We never had this in use, never promoted. Additionally, people might confuse it with ${user.home}/.m2 and it does not work because it is always set in wrapper script, Plexus conf sets in case of absence. You cannot use it anyway.
          Hide
          hboutemy Hervé Boutemy added a comment -

          I understand these last explanations: the default value cannot be used when Maven is launched with mvn script, and would only be used in an unexpected embedded situation with external launcher

          but there is no real bug as stated in initial explanation, that I was not understanding

          I'm ok to integrate this cleanup

          Show
          hboutemy Hervé Boutemy added a comment - I understand these last explanations: the default value cannot be used when Maven is launched with mvn script, and would only be used in an unexpected embedded situation with external launcher but there is no real bug as stated in initial explanation, that I was not understanding I'm ok to integrate this cleanup
          Hide
          michael-o Michael Osipov added a comment -

          Agreed.

          Show
          michael-o Michael Osipov added a comment - Agreed.
          Hide
          stephenc Stephen Connolly added a comment -

          Maven 3.4.0 has been dropped. See this thread for more details.

          This issue will need to be re-scheduled for a Maven release in the (hopefully near) future.

          Show
          stephenc Stephen Connolly added a comment - Maven 3.4.0 has been dropped. See this thread for more details. This issue will need to be re-scheduled for a Maven release in the (hopefully near) future.
          Hide
          michael-o Michael Osipov added a comment -
          Show
          michael-o Michael Osipov added a comment - Fixed with 5053a628c0a4eb069ab5512ad7491494207cb996 .
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build maven-3.x #1500 (See https://builds.apache.org/job/maven-3.x/1500/)
          MNG-6106 Remove maven.home setter from m2.conf (michaelo: http://git-wip-us.apache.org/repos/asf/?p=maven.git&a=commit&h=5053a628c0a4eb069ab5512ad7491494207cb996)

          • (edit) apache-maven/src/bin/m2.conf
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build maven-3.x #1500 (See https://builds.apache.org/job/maven-3.x/1500/ ) MNG-6106 Remove maven.home setter from m2.conf (michaelo: http://git-wip-us.apache.org/repos/asf/?p=maven.git&a=commit&h=5053a628c0a4eb069ab5512ad7491494207cb996 ) (edit) apache-maven/src/bin/m2.conf

            People

            • Assignee:
              michael-o Michael Osipov
              Reporter:
              michael-o Michael Osipov
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development