Details
-
Type:
Improvement
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 3.3.9
-
Fix Version/s: 3.5.0-alpha-1, 3.5.0
-
Component/s: None
-
Labels:
-
Flags:Patch
Description
The code linting tool PMD identified numerous places where Maven's string handling is inefficient. I've prepared a set of patches that should help speed things up.
The command I used was `pmd -d . -R java-strings`
Issue Links
- mentioned in
-
Page Loading...
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
Fixed with 8d91726f7872f4462d9fa085ef5b6f32bfd0a2e1.
Maven 3.4.0 has been dropped. See this thread for more details.
This issue will need to be re-scheduled for a Maven release in the (hopefully near) future.
Github user ChristianSchulte commented on the pull request:
https://github.com/apache/maven/pull/72#issuecomment-181984267
This has been committed. See MNG-5934. Please close this pull request manually.
SUCCESS: Integrated in maven-3.x #1195 (See https://builds.apache.org/job/maven-3.x/1195/)
MNG-5934 String handling issues identified by PMD Submitted by: Alex (schulte: rev 2d3b5811566190b52840e27cd04eb26bd02bb1b4)
- maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
- maven-compat/src/main/java/org/apache/maven/repository/metadata/MetadataGraphVertex.java
- maven-core/src/main/java/org/apache/maven/project/MavenProject.java
- maven-compat/src/main/java/org/apache/maven/repository/metadata/MetadataGraph.java
- maven-artifact/src/main/java/org/apache/maven/artifact/repository/ArtifactRepositoryPolicy.java
- maven-compat/src/test/java/org/apache/maven/project/LegacyLocalRepositoryManager.java
- maven-compat/src/main/java/org/apache/maven/artifact/versioning/ManagedVersionMap.java
- maven-builder-support/src/main/java/org/apache/maven/building/DefaultProblem.java
- maven-artifact/src/main/java/org/apache/maven/artifact/versioning/Restriction.java
- maven-core/src/main/java/org/apache/maven/artifact/repository/MavenArtifactRepository.java
- maven-core/src/main/java/org/apache/maven/lifecycle/LifecycleExecutionException.java
- maven-core/src/main/java/org/apache/maven/plugin/PluginParameterExpressionEvaluator.java
- maven-core/src/main/java/org/apache/maven/artifact/repository/metadata/AbstractRepositoryMetadata.java
- maven-embedder/src/main/java/org/apache/maven/cli/logging/impl/UnsupportedSlf4jBindingConfiguration.java
- maven-core/src/main/java/org/apache/maven/repository/ArtifactTransferEvent.java
- maven-artifact/src/main/java/org/apache/maven/artifact/versioning/DefaultArtifactVersion.java
- maven-embedder/src/test/java/org/apache/maven/cli/CLIManagerDocumentationTest.java
- maven-plugin-api/src/main/java/org/apache/maven/plugin/MojoNotFoundException.java
- maven-artifact/src/main/java/org/apache/maven/artifact/versioning/VersionRange.java
- maven-model-builder/src/main/java/org/apache/maven/model/building/ModelProblemUtils.java
- maven-core/src/test/java/org/apache/maven/project/LegacyLocalRepositoryManager.java
- maven-compat/src/main/java/org/apache/maven/project/validation/ModelValidationResult.java
- maven-core/src/main/java/org/apache/maven/repository/legacy/metadata/AbstractArtifactMetadata.java
- maven-compat/src/main/java/org/apache/maven/artifact/repository/DefaultArtifactRepository.java
- maven-embedder/src/main/java/org/apache/maven/cli/CLIReportingUtils.java
- maven-artifact/src/main/java/org/apache/maven/artifact/resolver/AbstractArtifactResolutionException.java
- maven-core/src/main/java/org/apache/maven/artifact/resolver/ArtifactResolutionResult.java
- maven-compat/src/test/java/org/apache/maven/project/inheritance/AbstractProjectInheritanceTestCase.java
- maven-embedder/src/main/java/org/apache/maven/cli/event/ExecutionEventLogger.java
- maven-settings-builder/src/main/java/org/apache/maven/settings/building/DefaultSettingsProblem.java
- maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelProblem.java
- maven-core/src/main/java/org/apache/maven/plugin/MojoExecution.java
- maven-artifact/src/main/java/org/apache/maven/artifact/DefaultArtifact.java
- maven-core/src/main/java/org/apache/maven/project/DefaultProjectDependenciesResolver.java
- maven-compat/src/main/java/org/apache/maven/repository/MetadataResolutionResult.java
- maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java
- maven-core/src/main/java/org/apache/maven/lifecycle/mapping/LifecyclePhase.java
- maven-artifact/src/main/java/org/apache/maven/artifact/resolver/MultipleArtifactsNotFoundException.java
- maven-core/src/main/java/org/apache/maven/plugin/PluginParameterException.java
Please open a pull request on GitHub, I will have a look.
SUCCESS: Integrated in Jenkins build maven-3.x #1543 (See https://builds.apache.org/job/maven-3.x/1543/)
MNG-5934String handling issues identified by PMD (michaelo: http://git-wip-us.apache.org/repos/asf/?p=maven.git&a=commit&h=8d91726f7872f4462d9fa085ef5b6f32bfd0a2e1)