Uploaded image for project: 'Maven'
  1. Maven
  2. MNG-5899

Reactor is no longer using the dependency reduced pom created by maven-shade-plugin

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Open
    • Major
    • Resolution: Unresolved
    • 3.3.1, 3.3.3
    • None
    • None
    • None

    Description

      This works with maven 3.2.5 and prior, but does not work with the latest releases (3.3.1 and 3.3.3), or master (tested against 3.3.7-SNAPSHOT).

      I did some bisecting and found the commit that caused the breakage:

      https://github.com/apache/maven/commit/be3fb200326208ca4b8c41ebf16d5ae6b8049792

      In particular, this commit introduced some code to not rebuild the model if it was already loaded during reactor resolution.

      This is causing maven not to use the dependency reduced pom created by the maven-shade-plugin.

      Removing this code fixes the situation. I'm hoping that code was just introduced as a performance optimization, and that I haven't broken anything functionally by removing it (the tests still pass at least).

      I will submit a pull request with the change for review.

      Here is the original maven-shade-plugin issue as reported by the Apache Storm team: https://issues.apache.org/jira/browse/MSHADE-206

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              traskstalnaker Trask Stalnaker
              Votes:
              18 Vote for this issue
              Watchers:
              27 Start watching this issue

              Dates

                Created:
                Updated: