Uploaded image for project: 'Maven'
  1. Maven
  2. MNG-5871

make url inheritance algorithm more visible

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.3.3
    • Fix Version/s: 3.3.9
    • Labels:
      None

      Description

      currently, default urls calculated for child from parent values are often discussed
      but their implementation is no easy to find: it's a mix between

      • DefaultInheritanceAssembler.getChildPathAdjustment(, which calculates path adjustment
      • MavenModelBuilder.appendPath, that calculates the child url: in general, parent url is used, but if childpathadjustment is set, this is the algorithm to extrapolate child from parent

      IMHO, the test on childpathadjustement is a hack; in fact, we should use method overriding: default method just returns arent, but DefaultInheritanceAssembler.InheritanceModelMerger should override it with the extrapolation algorithm

      this would make the code a lot more clear and help for future enhancements

        Attachments

        Issue Links

          Activity

            People

            • Assignee:
              hboutemy Herve Boutemy
              Reporter:
              hboutemy Herve Boutemy

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment