Uploaded image for project: 'Maven'
  1. Maven
  2. MNG-5776

Drop support for Win9x in mvn launch scripts

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.3.1
    • Component/s: Command Line
    • Labels:
      None
    • Environment:
      Windows

      Description

      The scripts mvn.bat / mvnDebug.bat contain a lot of clutter to maintain compatibility with Win9x/ME and the "4NT shell".

      Removing support for both will make the scripts a bit more maintainable and allow to reduce the duplication found in mvn.bat and mvnDebug.bat, which could also be renamed to *.cmd.

        Issue Links

          Activity

          Hide
          afloom Anders Hammar added a comment - - edited

          The system requirements text on the online page as well as in the distro (README.txt) should also be updated.

          Show
          afloom Anders Hammar added a comment - - edited The system requirements text on the online page as well as in the distro (README.txt) should also be updated.
          Hide
          agudian Andreas Gudian added a comment -

          Done, with c6faf8dd65587c3ea6d79ccf48e25bb7b90e18df

          The online pages need to be updated after the release. I'll keep an eye on that...

          Show
          agudian Andreas Gudian added a comment - Done, with c6faf8dd65587c3ea6d79ccf48e25bb7b90e18df The online pages need to be updated after the release. I'll keep an eye on that...
          Hide
          gslowikowski Grzegorz Slowikowski added a comment -

          Why actually you changed extensions from "bat" to "cmd"?

          Show
          gslowikowski Grzegorz Slowikowski added a comment - Why actually you changed extensions from "bat" to "cmd"?
          Hide
          agudian Andreas Gudian added a comment -

          .bat and .cmd have slightly different handlings of @setlocal / @endlocal and script invocations with "call". It's minor stuff, and, to be honest, I didn't see the problems with the invoker coming... (my local tests seem to have had some untidy PATH, so that the call to "mvn.bat" in maven-invoker based tests still worked)

          Show
          agudian Andreas Gudian added a comment - .bat and .cmd have slightly different handlings of @setlocal / @endlocal and script invocations with "call". It's minor stuff, and, to be honest, I didn't see the problems with the invoker coming... (my local tests seem to have had some untidy PATH, so that the call to "mvn.bat" in maven-invoker based tests still worked)
          Hide
          mbenson Matt Benson added a comment -

          Is there another issue open for the broken org.apache.maven.shared.invoker.MavenCommandLineBuilder then?

          Show
          mbenson Matt Benson added a comment - Is there another issue open for the broken org.apache.maven.shared.invoker.MavenCommandLineBuilder then?
          Hide
          pkg-elsevier Peter Kjær Guldbæk added a comment -

          I recently upgraded from Maven 3.0.4 to 3.3.1. It seems as if "mvn.cmd" does not indicate failure properly when using "&&".

          Invoking "mvn foo && echo SUCCESS!" using Maven 3.0.4 on Windows causes the following output (notice no trace of "SUCCESS!" as "mvn" fails):

          c:\Temp>mvn foo && echo SUCCESS!
          [INFO] Scanning for projects...
          [INFO] ------------------------------------------------------------------------
          [INFO] BUILD FAILURE
          [INFO] ------------------------------------------------------------------------
          [INFO] Total time: 0.061s
          [INFO] Finished at: Tue Apr 28 14:08:27 CEST 2015
          [INFO] Final Memory: 10M/491M
          [INFO] ------------------------------------------------------------------------
          [ERROR] The goal you specified requires a project to execute but there is no POM in this directory (c:\Temp). Please verify you invoked Maven from the
          correct directory. -> [Help 1]
          [ERROR]
          [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
          [ERROR] Re-run Maven using the -X switch to enable full debug logging.
          [ERROR]
          [ERROR] For more information about the errors and possible solutions, please read the following articles:
          [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MissingProjectException
          

          Invoking "mvn foo && echo SUCCESS!" using Maven 3.3.1 on Windows causes the following output (notice "SUCCESS!" is echoed even though "mvn" fails):

          c:\Temp>mvn foo && echo SUCCESS!
          [INFO] Scanning for projects...
          [INFO] ------------------------------------------------------------------------
          [INFO] BUILD FAILURE
          [INFO] ------------------------------------------------------------------------
          [INFO] Total time: 0.053 s
          [INFO] Finished at: 2015-04-28T14:09:19+02:00
          [INFO] Final Memory: 13M/491M
          [INFO] ------------------------------------------------------------------------
          [ERROR] The goal you specified requires a project to execute but there is no POM in this directory (c:\Temp). Please verify you invoked Maven from the
          correct directory. -> [Help 1]
          [ERROR]
          [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
          [ERROR] Re-run Maven using the -X switch to enable full debug logging.
          [ERROR]
          [ERROR] For more information about the errors and possible solutions, please read the following articles:
          [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MissingProjectException
          SUCCESS!
          

          It is a little strange that it does not work in Maven 3.3.1 as invoking "mvn foo" actually causes "%ERRORLEVEL%" to be set to "1":

          c:\Temp>mvn foo
          [INFO] Scanning for projects...
          [INFO] ------------------------------------------------------------------------
          [INFO] BUILD FAILURE
          [INFO] ------------------------------------------------------------------------
          [INFO] Total time: 0.052 s
          [INFO] Finished at: 2015-04-28T14:09:41+02:00
          [INFO] Final Memory: 13M/491M
          [INFO] ------------------------------------------------------------------------
          [ERROR] The goal you specified requires a project to execute but there is no POM in this directory (c:\Temp). Please verify you invoked Maven from the
          correct directory. -> [Help 1]
          [ERROR]
          [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
          [ERROR] Re-run Maven using the -X switch to enable full debug logging.
          [ERROR]
          [ERROR] For more information about the errors and possible solutions, please read the following articles:
          [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MissingProjectException
          
          c:\Temp>echo %ERRORLEVEL%
          1
          
          Show
          pkg-elsevier Peter Kjær Guldbæk added a comment - I recently upgraded from Maven 3.0.4 to 3.3.1. It seems as if "mvn.cmd" does not indicate failure properly when using "&&". Invoking "mvn foo && echo SUCCESS!" using Maven 3.0.4 on Windows causes the following output (notice no trace of "SUCCESS!" as "mvn" fails): c:\Temp>mvn foo && echo SUCCESS! [INFO] Scanning for projects... [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 0.061s [INFO] Finished at: Tue Apr 28 14:08:27 CEST 2015 [INFO] Final Memory: 10M/491M [INFO] ------------------------------------------------------------------------ [ERROR] The goal you specified requires a project to execute but there is no POM in this directory (c:\Temp). Please verify you invoked Maven from the correct directory. -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MissingProjectException Invoking "mvn foo && echo SUCCESS!" using Maven 3.3.1 on Windows causes the following output (notice "SUCCESS!" is echoed even though "mvn" fails): c:\Temp>mvn foo && echo SUCCESS! [INFO] Scanning for projects... [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 0.053 s [INFO] Finished at: 2015-04-28T14:09:19+02:00 [INFO] Final Memory: 13M/491M [INFO] ------------------------------------------------------------------------ [ERROR] The goal you specified requires a project to execute but there is no POM in this directory (c:\Temp). Please verify you invoked Maven from the correct directory. -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MissingProjectException SUCCESS! It is a little strange that it does not work in Maven 3.3.1 as invoking "mvn foo" actually causes "%ERRORLEVEL%" to be set to "1": c:\Temp>mvn foo [INFO] Scanning for projects... [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 0.052 s [INFO] Finished at: 2015-04-28T14:09:41+02:00 [INFO] Final Memory: 13M/491M [INFO] ------------------------------------------------------------------------ [ERROR] The goal you specified requires a project to execute but there is no POM in this directory (c:\Temp). Please verify you invoked Maven from the correct directory. -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MissingProjectException c:\Temp>echo %ERRORLEVEL% 1
          Hide
          michael-o Michael Osipov added a comment -

          Please create another issue for that.

          Show
          michael-o Michael Osipov added a comment - Please create another issue for that.
          Hide
          pkg-elsevier Peter Kjær Guldbæk added a comment -

          Sorry about that. I have created MNG-5815. Feel free to delete my comments on this issue if needed.

          Show
          pkg-elsevier Peter Kjær Guldbæk added a comment - Sorry about that. I have created MNG-5815 . Feel free to delete my comments on this issue if needed.

            People

            • Assignee:
              agudian Andreas Gudian
              Reporter:
              agudian Andreas Gudian
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development