[MNG-5729] Measure (build time) durations with System.nanoTime only

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.2.3
• Fix Version/s: 4.0.0-rc-2
• Component/s: Embedding, General, Logging, Performance, Reactor and Workspace
• Assignee: Guillaume Nodet
• Reporter: Michael Osipov
• Created: 29/Nov/14 06:41
• Updated: 5 days ago 23:03
• Resolved: 5 days ago 23:03

Description

Currently, we solely rely on System.currentTimeMillis to track start/end times as well as durations. This is error prone and not guaranteed to deliver a monotic value with positive durations.

We should consider employing System.nanoTime throughout the core where the above mentioned conditions are met. E.g., in some of:

maven-aether-provider/src/test/java/org/apache/maven/repository/internal/util/ConsoleTransferListener.java: long duration = System.currentTimeMillis() - resource.getTransferStartTime();
maven-compat/src/main/java/org/apache/maven/repository/legacy/MavenArtifact.java: this.transferStartTime = System.currentTimeMillis();
maven-core/src/main/java/org/apache/maven/lifecycle/internal/builder/BuilderCommon.java: long buildEndTime = System.currentTimeMillis();
maven-core/src/main/java/org/apache/maven/lifecycle/internal/LifecycleModuleBuilder.java: long buildStartTime = System.currentTimeMillis();
maven-core/src/main/java/org/apache/maven/lifecycle/internal/LifecycleModuleBuilder.java: long buildEndTime = System.currentTimeMillis();
maven-embedder/src/main/java/org/apache/maven/cli/event/ExecutionEventLogger.java: long finish = System.currentTimeMillis();
maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java: long duration = System.currentTimeMillis() - resource.getTransferStartTime();
maven-embedder/src/main/java/org/apache/maven/cli/transfer/Slf4jMavenTransferListener.java: long duration = System.currentTimeMillis() - resource.getTransferStartTime();
DefaultMaven.java: request.setStartTime( new Date() ); 
DefaultMavenExecutionRequest.java: public Date getStartTime() 
DefaultMavenExecutionRequest.java: projectBuildingRequest.setBuildStartTime( getStartTime() ); 
MavenExecutionRequest.java: Date getStartTime(); 
MavenSession.java: public Date getStartTime() 
MavenSession.java: return request.getStartTime(); 
ExecutionEventLogger.java: long time = finish - session.getRequest().getStartTime().getTime(); 

and all other code spots where Date or long is used.

Issue Links

• is blocked by: MRESOLVER-14 Statistics should be calculated using System.nanoTime() instead of System.currentTimeMillis()
• is depended upon by: MNG-5626 Avoid negative durations or handle them correctly
• requires: MRESOLVER-635 Use Instant instead of untyped millis for TransferResource startTime
• links to: GitHub Pull Request #1965
• links to: GitHub Pull Request #1969
• links to: GitHub Pull Request #1972