[MNG-5662] org.apache.maven.profiles.activation.JdkPrefixProfileActivator misuses String.replaceAll

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Won't Fix
• Component/s: Profiles
• Assignee: Unassigned
• Reporter: Gábor Lipták
• Created: 09/Jul/14 04:06
• Updated: 23/Jul/14 08:55
• Resolved: 23/Jul/14 08:55

Description

Instead of this:

    private String convertJdkToMavenVersion( String jdk )
    {
        return jdk.replaceAll( "_", "-" );
    }

It should look like this:

    private String convertJdkToMavenVersion( String jdk )
    {
        return jdk.replace( '_', '-' );
    }

This would save the CPU from recompiling a regex in vain. Could make a performance improvement for projects using that profile activator massively.