Uploaded image for project: 'Maven'
  1. Maven
  2. MNG-5457

Show repository id when downloading or uploading from/to a remote repository

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.5
    • Fix Version/s: 3.5.2
    • Component/s: General
    • Labels:
      None

      Description

      currently, the log only show the url being downloaded:

      Downloading: http://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-plugins/23/maven-plugins-23.pom
      Downloaded: http://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-plugins/23/maven-plugins-23.pom (9 KB at 98.7 KB/sec)

      nothing is told about the repository id.
      But as shown in MNG-5181, repository id is an important information since it is stored in local repository to limit artifact scope: it would be useful IMHO to display the id in the output, like

      Downloading from central: http://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-plugins/23/maven-plugins-23.pom
      Downloaded from central: http://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-plugins/23/maven-plugins-23.pom (9 KB at 98.7 KB/sec)

        Issue Links

          Activity

          Hide
          michael-o Michael Osipov added a comment -

          Is this list of repos a viable source for the repo? Should I pick the repo in element 0?

          Show
          michael-o Michael Osipov added a comment - Is this list of repos a viable source for the repo? Should I pick the repo in element 0?
          Hide
          rajivpj Rajiv Jain added a comment -

          I will take a look and try to implement this fix.

          Show
          rajivpj Rajiv Jain added a comment - I will take a look and try to implement this fix.
          Hide
          rajivpj Rajiv Jain added a comment -

          Hi

          Can somebody help me please? I am working on this and this is the first time that I am working with Apache as a contributor. I have checked out the current development branch (master). I can see a class called ConsoleTransferListener.java that I believe the change needs to (in TransferResource).

          However, the ConsoleTransferListener.java is in within src/test/java. Any ideas why this is located here? Am I looking in the correct part of the code?

          Thanks.

          Show
          rajivpj Rajiv Jain added a comment - Hi Can somebody help me please? I am working on this and this is the first time that I am working with Apache as a contributor. I have checked out the current development branch (master). I can see a class called ConsoleTransferListener.java that I believe the change needs to (in TransferResource). However, the ConsoleTransferListener.java is in within src/test/java. Any ideas why this is located here? Am I looking in the correct part of the code? Thanks.
          Hide
          michael-o Michael Osipov added a comment -

          Have a look at my screenshot you should see all involved classes.

          Show
          michael-o Michael Osipov added a comment - Have a look at my screenshot you should see all involved classes.
          Hide
          rajivpj Rajiv Jain added a comment -

          Michael Osipov Thanks. Would I find these classes in the maven-core module?

          If I remember correctly, some of the classes in the screenshot refer to the Eclipse source code. That's why I thought some changes need to occur within the Eclipse side. I think the ConsoleTransferListener.java contains the actual code need to be modified. Could you please clarify?

          Thanks.

          Show
          rajivpj Rajiv Jain added a comment - Michael Osipov Thanks. Would I find these classes in the maven-core module? If I remember correctly, some of the classes in the screenshot refer to the Eclipse source code. That's why I thought some changes need to occur within the Eclipse side. I think the ConsoleTransferListener.java contains the actual code need to be modified. Could you please clarify? Thanks.
          Hide
          michael-o Michael Osipov added a comment -

          The class in question is ConsoleTransferListener but the repo ID is burried in Aether code. As you can see in the screenshot, there is a list of repos along with its IDs though I am not familiar enough with the Aether code to tell which is the right spot to obtain the proper repo ID.

          Show
          michael-o Michael Osipov added a comment - The class in question is ConsoleTransferListener but the repo ID is burried in Aether code. As you can see in the screenshot, there is a list of repos along with its IDs though I am not familiar enough with the Aether code to tell which is the right spot to obtain the proper repo ID.
          Hide
          rajivpj Rajiv Jain added a comment -

          So, if I modify the Eclipse Ather code how will this be modified in the Apache Maven source code? What is the process for this?

          In addition, would you know why the ConsoleTransferListener class is within src/test/java folder? It does not make sense.

          Thanks.

          Sent from my iPhone

          Show
          rajivpj Rajiv Jain added a comment - So, if I modify the Eclipse Ather code how will this be modified in the Apache Maven source code? What is the process for this? In addition, would you know why the ConsoleTransferListener class is within src/test/java folder? It does not make sense. Thanks. Sent from my iPhone
          Hide
          michael-o Michael Osipov added a comment - - edited

          Wrong place. You are looking for AbstractMavenTransferListener.
          I do not know wether Aether has to be enhanced, maybe. You need to figure it out if it will do w/o modification.

          Show
          michael-o Michael Osipov added a comment - - edited Wrong place. You are looking for AbstractMavenTransferListener . I do not know wether Aether has to be enhanced, maybe. You need to figure it out if it will do w/o modification.
          Hide
          rajivpj Rajiv Jain added a comment -

          Thanks for the quick reply. I will take a look tomorrow and hopefully get a fix out.

          Thanks once again.

          Sent from my iPhone

          Show
          rajivpj Rajiv Jain added a comment - Thanks for the quick reply. I will take a look tomorrow and hopefully get a fix out. Thanks once again. Sent from my iPhone
          Hide
          rajivpj Rajiv Jain added a comment - - edited

          Michael Osipov - I have been trying to debug this issue but having some problems. First of all, I am trying to find out whether the AbstractMavenTransferListener transferInitiated() what are the value of the resource.getResourceName().

          Please see below:

          @Override
          public void transferInitiated( TransferEvent event )

          { String type = event.getRequestType() == TransferEvent.RequestType.PUT ? "Uploading" : "Downloading"; TransferResource resource = event.getResource(); out.println( type + ": " + resource.getRepositoryUrl() + resource.getResourceName() ); }

          From the description from the above and from what I have seen I have always seen: Downloading: URL. I have never seen the output of the resource.getResourceName().

          Could you give any insight to this? How can I actually debug? I have got far as debugging the MavenCli.java, but I don't know what properties etc need to be set.

          Thanks.

          Show
          rajivpj Rajiv Jain added a comment - - edited Michael Osipov - I have been trying to debug this issue but having some problems. First of all, I am trying to find out whether the AbstractMavenTransferListener transferInitiated() what are the value of the resource.getResourceName(). Please see below: @Override public void transferInitiated( TransferEvent event ) { String type = event.getRequestType() == TransferEvent.RequestType.PUT ? "Uploading" : "Downloading"; TransferResource resource = event.getResource(); out.println( type + ": " + resource.getRepositoryUrl() + resource.getResourceName() ); } From the description from the above and from what I have seen I have always seen: Downloading: URL. I have never seen the output of the resource.getResourceName(). Could you give any insight to this? How can I actually debug? I have got far as debugging the MavenCli.java, but I don't know what properties etc need to be set. Thanks.
          Hide
          michael-o Michael Osipov added a comment -

          There is no connection between getResourceName() and the repo id. Don't waste your time.

          Show
          michael-o Michael Osipov added a comment - There is no connection between getResourceName() and the repo id. Don't waste your time.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user rajivpjs opened a pull request:

          https://github.com/apache/maven/pull/87

          MNG-5457 Added the repository id to show which repository is being …

          I have added the repository id within both the AbstractMavenTransferListener.java & Slf4jMavenTransferListener.java.

          Hopefully, this should fix this issue.

          Please review and let me know of any changes.

          Thanks.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/rajivpjs/maven MNG-5457

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/maven/pull/87.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #87


          commit bce48f9c24120df3a0fd2e5ae04f369683013fa1
          Author: Rajiv Jain <rajivpjs@gmail.com>
          Date: 2016-07-14T22:30:21Z

          MNG-5457 Added the repository id to show which repository is being handled


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user rajivpjs opened a pull request: https://github.com/apache/maven/pull/87 MNG-5457 Added the repository id to show which repository is being … I have added the repository id within both the AbstractMavenTransferListener.java & Slf4jMavenTransferListener.java. Hopefully, this should fix this issue. Please review and let me know of any changes. Thanks. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajivpjs/maven MNG-5457 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven/pull/87.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #87 commit bce48f9c24120df3a0fd2e5ae04f369683013fa1 Author: Rajiv Jain <rajivpjs@gmail.com> Date: 2016-07-14T22:30:21Z MNG-5457 Added the repository id to show which repository is being handled
          Hide
          rajivpj Rajiv Jain added a comment -

          Michael Osipov - Thanks for your advice. I really appreciate that you put me back on track. I have now requested a pull request with my change.

          Hopefully, the change should be fine.

          Thanks.

          Show
          rajivpj Rajiv Jain added a comment - Michael Osipov - Thanks for your advice. I really appreciate that you put me back on track. I have now requested a pull request with my change. Hopefully, the change should be fine. Thanks.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user michael-o commented on the issue:

          https://github.com/apache/maven/pull/87

          Unusable. `getLocalRepository()` always gives you your local repository on disk. This is not the remote repository Aether is pulling from or pushing to. Hence, you will always see `...local...:`.

          Show
          githubbot ASF GitHub Bot added a comment - Github user michael-o commented on the issue: https://github.com/apache/maven/pull/87 Unusable. `getLocalRepository()` always gives you your local repository on disk. This is not the remote repository Aether is pulling from or pushing to. Hence, you will always see `...local...:`.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user rajivpjs commented on the issue:

          https://github.com/apache/maven/pull/87

          I am working on another fix.

          Thanks.

          Show
          githubbot ASF GitHub Bot added a comment - Github user rajivpjs commented on the issue: https://github.com/apache/maven/pull/87 I am working on another fix. Thanks.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user michael-o commented on the issue:

          https://github.com/apache/maven/pull/87

          This looks better. Can you squash the commit? Additionally, this requires an integration test with three repos: central (by default), and two others. Preferably file-based. We'd see that this works.

          Show
          githubbot ASF GitHub Bot added a comment - Github user michael-o commented on the issue: https://github.com/apache/maven/pull/87 This looks better. Can you squash the commit? Additionally, this requires an integration test with three repos: central (by default), and two others. Preferably file-based. We'd see that this works.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user rajivpjs commented on the issue:

          https://github.com/apache/maven/pull/87

          What do you mean by squash the commit? Do you have any examples of Integration tests for Apache way of doing things?

          Thanks.

          > On 15 Jul 2016, at 18:37, Michael Osipov <notifications@github.com> wrote:
          >
          > This looks better. Can you squash the commit? Additionally, this requires an integration test with three repos: central (by default), and two others. Preferably file-based. We'd see that this works.
          >
          > —
          > You are receiving this because you authored the thread.
          > Reply to this email directly, view it on GitHub <https://github.com/apache/maven/pull/87#issuecomment-233017254>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AQ41MB9LLirrefGlMT1Exbq2acdCQKOEks5qV8VHgaJpZM4JM6iW>.
          >

          Show
          githubbot ASF GitHub Bot added a comment - Github user rajivpjs commented on the issue: https://github.com/apache/maven/pull/87 What do you mean by squash the commit? Do you have any examples of Integration tests for Apache way of doing things? Thanks. > On 15 Jul 2016, at 18:37, Michael Osipov <notifications@github.com> wrote: > > This looks better. Can you squash the commit? Additionally, this requires an integration test with three repos: central (by default), and two others. Preferably file-based. We'd see that this works. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub < https://github.com/apache/maven/pull/87#issuecomment-233017254 >, or mute the thread < https://github.com/notifications/unsubscribe-auth/AQ41MB9LLirrefGlMT1Exbq2acdCQKOEks5qV8VHgaJpZM4JM6iW >. >
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user michael-o commented on the issue:

          https://github.com/apache/maven/pull/87

          [Squashing commits](http://stackoverflow.com/a/5189600/696632). We have a complete test set of IT [here](https://maven.apache.org/core-its/). There is a [bus load](https://github.com/apache/maven-integration-testing/tree/31780e49d00ad5be0dd80ee5b37483f624bbf394/core-it-suite/src/test/resources) of them. Find one with an internal repo for resting. You IT would show that your approach actually works.

          Show
          githubbot ASF GitHub Bot added a comment - Github user michael-o commented on the issue: https://github.com/apache/maven/pull/87 [Squashing commits] ( http://stackoverflow.com/a/5189600/696632 ). We have a complete test set of IT [here] ( https://maven.apache.org/core-its/ ). There is a [bus load] ( https://github.com/apache/maven-integration-testing/tree/31780e49d00ad5be0dd80ee5b37483f624bbf394/core-it-suite/src/test/resources ) of them. Find one with an internal repo for resting. You IT would show that your approach actually works.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user michael-o commented on the issue:

          https://github.com/apache/maven/pull/87

          Just, it does not work. The list you are using is a static list of ordered repos to be tried. The first one does not denote the one to be used. From Maven build:

          [INFO] ------------------------------------------------------------------------
          [INFO] Building Apache Maven Distribution 3.4.0-SNAPSHOT
          [INFO] ------------------------------------------------------------------------
          Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-compiler-plugin/3.5.1/maven-compiler-plugin-3.5.1.pom
          Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-compiler-plugin/3.5.1/maven-compiler-plugin-3.5.1.pom (10 kB at 19 kB/s)
          Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-compiler-plugin/3.5.1/maven-compiler-plugin-3.5.1.jar
          Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-compiler-plugin/3.5.1/maven-compiler-plugin-3.5.1.jar (50 kB at 292 kB/s)
          Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-surefire-plugin/2.19.1/maven-surefire-plugin-2.19.1.pom
          Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-surefire-plugin/2.19.1/maven-surefire-plugin-2.19.1.pom (5.6 kB at 48 kB/s)
          Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/surefire/surefire/2.19.1/surefire-2.19.1.pom
          Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/maven/surefire/surefire/2.19.1/surefire-2.19.1.pom (18 kB at 121 kB/s)
          Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-surefire-plugin/2.19.1/maven-surefire-plugin-2.19.1.jar
          Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-surefire-plugin/2.19.1/maven-surefire-plugin-2.19.1.jar (38 kB at 191 kB/s)
          Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-assembly-plugin/2.6/maven-assembly-plugin-2.6.pom
          Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-assembly-plugin/2.6/maven-assembly-plugin-2.6.pom (16 kB at 112 kB/s)
          Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-assembly-plugin/2.6/maven-assembly-plugin-2.6.jar
          Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-assembly-plugin/2.6/maven-assembly-plugin-2.6.jar (246 kB at 524 kB/s)
          Downloading from central: https://repository.apache.org/snapshots/org/apache/maven/maven-embedder/3.4.0-SNAPSHOT/maven-embedder-3.4.0-20160712.211951-154.pom
          Downloaded from central: https://repository.apache.org/snapshots/org/apache/maven/maven-embedder/3.4.0-SNAPSHOT/maven-embedder-3.4.0-20160712.211951-154.pom (6.4 kB at 6.7 kB/s)
          Progress (1): 815 B

          Note the snapshots at the end.

          Show
          githubbot ASF GitHub Bot added a comment - Github user michael-o commented on the issue: https://github.com/apache/maven/pull/87 Just, it does not work. The list you are using is a static list of ordered repos to be tried. The first one does not denote the one to be used. From Maven build: [INFO] ------------------------------------------------------------------------ [INFO] Building Apache Maven Distribution 3.4.0-SNAPSHOT [INFO] ------------------------------------------------------------------------ Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-compiler-plugin/3.5.1/maven-compiler-plugin-3.5.1.pom Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-compiler-plugin/3.5.1/maven-compiler-plugin-3.5.1.pom (10 kB at 19 kB/s) Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-compiler-plugin/3.5.1/maven-compiler-plugin-3.5.1.jar Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-compiler-plugin/3.5.1/maven-compiler-plugin-3.5.1.jar (50 kB at 292 kB/s) Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-surefire-plugin/2.19.1/maven-surefire-plugin-2.19.1.pom Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-surefire-plugin/2.19.1/maven-surefire-plugin-2.19.1.pom (5.6 kB at 48 kB/s) Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/surefire/surefire/2.19.1/surefire-2.19.1.pom Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/maven/surefire/surefire/2.19.1/surefire-2.19.1.pom (18 kB at 121 kB/s) Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-surefire-plugin/2.19.1/maven-surefire-plugin-2.19.1.jar Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-surefire-plugin/2.19.1/maven-surefire-plugin-2.19.1.jar (38 kB at 191 kB/s) Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-assembly-plugin/2.6/maven-assembly-plugin-2.6.pom Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-assembly-plugin/2.6/maven-assembly-plugin-2.6.pom (16 kB at 112 kB/s) Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-assembly-plugin/2.6/maven-assembly-plugin-2.6.jar Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-assembly-plugin/2.6/maven-assembly-plugin-2.6.jar (246 kB at 524 kB/s) Downloading from central: https://repository.apache.org/snapshots/org/apache/maven/maven-embedder/3.4.0-SNAPSHOT/maven-embedder-3.4.0-20160712.211951-154.pom Downloaded from central: https://repository.apache.org/snapshots/org/apache/maven/maven-embedder/3.4.0-SNAPSHOT/maven-embedder-3.4.0-20160712.211951-154.pom (6.4 kB at 6.7 kB/s) Progress (1): 815 B Note the snapshots at the end.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user rajivpjs commented on the issue:

          https://github.com/apache/maven/pull/87

          In your example, where is the snapshots at the end? Are we saying repository at index 0, is not correct? If yes, what is the best way to determine which repository is correct?

          Show
          githubbot ASF GitHub Bot added a comment - Github user rajivpjs commented on the issue: https://github.com/apache/maven/pull/87 In your example, where is the snapshots at the end? Are we saying repository at index 0, is not correct? If yes, what is the best way to determine which repository is correct?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user michael-o commented on the issue:

          https://github.com/apache/maven/pull/87

          This is the snapshot: `Downloading from central: https://repository.apache.org/snapshots/org/apache/maven/maven-embedder/3.4.0-SNAPSHOT/maven-embedder-3.4.0-20160712.211951-154.pom`

          Unfortunately, the mediated repo is only known to Aether. I have to fix this issue long time ago but was stuck at the same point. I think it won't work without an Aether fix.

          Show
          githubbot ASF GitHub Bot added a comment - Github user michael-o commented on the issue: https://github.com/apache/maven/pull/87 This is the snapshot: `Downloading from central: https://repository.apache.org/snapshots/org/apache/maven/maven-embedder/3.4.0-SNAPSHOT/maven-embedder-3.4.0-20160712.211951-154.pom ` Unfortunately, the mediated repo is only known to Aether. I have to fix this issue long time ago but was stuck at the same point. I think it won't work without an Aether fix.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user rajivpjs commented on the issue:

          https://github.com/apache/maven/pull/87

          "Since Aether is currently in transition to us" - what do you mean? Is Aether going to come to Apache When do you think we will be able to fix this?

          Show
          githubbot ASF GitHub Bot added a comment - Github user rajivpjs commented on the issue: https://github.com/apache/maven/pull/87 "Since Aether is currently in transition to us" - what do you mean? Is Aether going to come to Apache When do you think we will be able to fix this?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user michael-o commented on the issue:

          https://github.com/apache/maven/pull/87

          > "Since Aether is currently in transition to us" - what do you mean? Is Aether going to come to Apache When do you think we will be able to fix this?

          I think so, we will at least be able to add `getRemoteRepositoryId()`.

          > In the meantime, should I leave this pull request open?

          You can do that and rework the PR as soon as Aether has reached the appropriate state.

          Show
          githubbot ASF GitHub Bot added a comment - Github user michael-o commented on the issue: https://github.com/apache/maven/pull/87 > "Since Aether is currently in transition to us" - what do you mean? Is Aether going to come to Apache When do you think we will be able to fix this? I think so, we will at least be able to add `getRemoteRepositoryId()`. > In the meantime, should I leave this pull request open? You can do that and rework the PR as soon as Aether has reached the appropriate state.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user rajivpjs commented on the issue:

          https://github.com/apache/maven/pull/87

          Sure. I will close this for now and will reopen when we know Aether has reached the appropriate state.

          Thanks.

          Show
          githubbot ASF GitHub Bot added a comment - Github user rajivpjs commented on the issue: https://github.com/apache/maven/pull/87 Sure. I will close this for now and will reopen when we know Aether has reached the appropriate state. Thanks.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user rajivpjs closed the pull request at:

          https://github.com/apache/maven/pull/87

          Show
          githubbot ASF GitHub Bot added a comment - Github user rajivpjs closed the pull request at: https://github.com/apache/maven/pull/87
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user michael-o commented on the issue:

          https://github.com/apache/maven/pull/87

          @rajivpjs I think I know the spot to fix in Aether, though I am not familiar with the Aether code. Give me 15 min.

          Show
          githubbot ASF GitHub Bot added a comment - Github user michael-o commented on the issue: https://github.com/apache/maven/pull/87 @rajivpjs I think I know the spot to fix in Aether, though I am not familiar with the Aether code. Give me 15 min.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user rajivpjs commented on the issue:

          https://github.com/apache/maven/pull/87

          ok cool. I will wait for your reply.

          Thanks.

          Show
          githubbot ASF GitHub Bot added a comment - Github user rajivpjs commented on the issue: https://github.com/apache/maven/pull/87 ok cool. I will wait for your reply. Thanks.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user michael-o commented on the issue:

          https://github.com/apache/maven/pull/87

          I just have patched Aether, let's see wether Maven will accept 1.1.0-SNAPSHOT.

          Show
          githubbot ASF GitHub Bot added a comment - Github user michael-o commented on the issue: https://github.com/apache/maven/pull/87 I just have patched Aether, let's see wether Maven will accept 1.1.0-SNAPSHOT.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user michael-o commented on the issue:

          https://github.com/apache/maven/pull/87

          You can always watch dev@maven.apache.org.

          Show
          githubbot ASF GitHub Bot added a comment - Github user michael-o commented on the issue: https://github.com/apache/maven/pull/87 You can always watch dev@maven.apache.org.
          Show
          githubbot ASF GitHub Bot added a comment - Github user michael-o commented on the issue: https://github.com/apache/maven/pull/87 My patch works: Downloaded from central: https://repo.maven.apache.org/maven2/org/sonatype/forge/forge-parent/5/forge-parent-5.pom (8.4 kB at 55 kB/s) Downloading from apache.snapshots: https://repository.apache.org/snapshots/org/apache/maven/maven-core/3.4.0-SNAPSHOT/maven-metadata.xml Downloaded from apache.snapshots: https://repository.apache.org/snapshots/org/apache/maven/maven-core/3.4.0-SNAPSHOT/maven-metadata.xml (782 B at 199 B/s) Downloading from apache.snapshots: https://repository.apache.org/snapshots/org/apache/maven/maven-core/3.4.0-SNAPSHOT/maven-core-3.4.0-20160712.211941-155.pom Downloaded from apache.snapshots: https://repository.apache.org/snapshots/org/apache/maven/maven-core/3.4.0-SNAPSHOT/maven-core-3.4.0-20160712.211941-155.pom (8.8 kB at 2.1 kB/s) I will push my changes shortly.
          Hide
          githubbot ASF GitHub Bot added a comment -
          Show
          githubbot ASF GitHub Bot added a comment - Github user michael-o commented on the issue: https://github.com/apache/maven/pull/87 Here is the Aether change: https://github.com/michael-o/aether-core/commit/942fc4122d803225c2b465831ef1378bb9946669
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user rajivpjs commented on the issue:

          https://github.com/apache/maven/pull/87

          That's great. Well done!

          I can see only the Aether changes were made. Did you make any Apache Maven changes? The text "from" in "Downloading from central", how was that appended?

          Show
          githubbot ASF GitHub Bot added a comment - Github user rajivpjs commented on the issue: https://github.com/apache/maven/pull/87 That's great. Well done! I can see only the Aether changes were made. Did you make any Apache Maven changes? The text "from" in "Downloading from central", how was that appended?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user michael-o commented on the issue:

          https://github.com/apache/maven/pull/87

          The branch is already in preparation.

          Show
          githubbot ASF GitHub Bot added a comment - Github user michael-o commented on the issue: https://github.com/apache/maven/pull/87 The branch is already in preparation.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user rajivpjs commented on the issue:

          https://github.com/apache/maven/pull/87

          Which branch should I be looking at and in which project?

          Show
          githubbot ASF GitHub Bot added a comment - Github user rajivpjs commented on the issue: https://github.com/apache/maven/pull/87 Which branch should I be looking at and in which project?
          Hide
          githubbot ASF GitHub Bot added a comment -
          Show
          githubbot ASF GitHub Bot added a comment - Github user michael-o commented on the issue: https://github.com/apache/maven/pull/87 Here is the Maven change: https://github.com/michael-o/maven/commit/fd1f665225cea9cdee84cad3de193f771d82e42d
          Show
          michael-o Michael Osipov added a comment - This issue can be resolved by applying this change to Aether: https://github.com/michael-o/aether-core/commit/9d6ea3ab67ceeb9cb1de301fd93487512183001a and this change to Maven: https://github.com/michael-o/maven/commit/fd1f665225cea9cdee84cad3de193f771d82e42d
          Hide
          michael-o Michael Osipov added a comment -

          Feature has been added to Maven Resolver. Waiting for release 1.2.

          Show
          michael-o Michael Osipov added a comment - Feature has been added to Maven Resolver. Waiting for release 1.2.
          Hide
          michael-o Michael Osipov added a comment -
          Show
          michael-o Michael Osipov added a comment - Fixed with 8a1b6359f31178ce804018cfb524e72f1178028a .
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Jenkins build maven-3.x #1454 (See https://builds.apache.org/job/maven-3.x/1454/)
          MNG-5457 Show repository id when downloading or uploading from/to a (michaelo: rev 8a1b6359f31178ce804018cfb524e72f1178028a)

          • (edit) maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java
          • (edit) maven-embedder/src/main/java/org/apache/maven/cli/transfer/Slf4jMavenTransferListener.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Jenkins build maven-3.x #1454 (See https://builds.apache.org/job/maven-3.x/1454/ ) MNG-5457 Show repository id when downloading or uploading from/to a (michaelo: rev 8a1b6359f31178ce804018cfb524e72f1178028a) (edit) maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java (edit) maven-embedder/src/main/java/org/apache/maven/cli/transfer/Slf4jMavenTransferListener.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build maven-3.x Jigsaw #46 (See https://builds.apache.org/job/maven-3.x%20Jigsaw/46/)
          MNG-5457 Show repository id when downloading or uploading from/to a (michaelo: rev 8a1b6359f31178ce804018cfb524e72f1178028a)

          • (edit) maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java
          • (edit) maven-embedder/src/main/java/org/apache/maven/cli/transfer/Slf4jMavenTransferListener.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build maven-3.x Jigsaw #46 (See https://builds.apache.org/job/maven-3.x%20Jigsaw/46/ ) MNG-5457 Show repository id when downloading or uploading from/to a (michaelo: rev 8a1b6359f31178ce804018cfb524e72f1178028a) (edit) maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java (edit) maven-embedder/src/main/java/org/apache/maven/cli/transfer/Slf4jMavenTransferListener.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build maven-3.x Jigsaw #47 (See https://builds.apache.org/job/maven-3.x%20Jigsaw/47/)
          Revert "MNG-5457 Show repository id when downloading or uploading (schulte: rev 2385484a813edc157ba151c9daa0625eaf8902f9)

          • (edit) maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java
          • (edit) maven-embedder/src/main/java/org/apache/maven/cli/transfer/Slf4jMavenTransferListener.java
            MNG-5457 Show repository id when downloading or uploading from/to a (schulte: rev ff5d215b54cb9a77e3742dc5dd05865dec08795b)
          • (edit) maven-embedder/src/main/java/org/apache/maven/cli/transfer/Slf4jMavenTransferListener.java
          • (edit) maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build maven-3.x Jigsaw #47 (See https://builds.apache.org/job/maven-3.x%20Jigsaw/47/ ) Revert " MNG-5457 Show repository id when downloading or uploading (schulte: rev 2385484a813edc157ba151c9daa0625eaf8902f9) (edit) maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java (edit) maven-embedder/src/main/java/org/apache/maven/cli/transfer/Slf4jMavenTransferListener.java MNG-5457 Show repository id when downloading or uploading from/to a (schulte: rev ff5d215b54cb9a77e3742dc5dd05865dec08795b) (edit) maven-embedder/src/main/java/org/apache/maven/cli/transfer/Slf4jMavenTransferListener.java (edit) maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build maven-3.x #1456 (See https://builds.apache.org/job/maven-3.x/1456/)
          Revert "MNG-5457 Show repository id when downloading or uploading (schulte: rev 2385484a813edc157ba151c9daa0625eaf8902f9)

          • (edit) maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java
          • (edit) maven-embedder/src/main/java/org/apache/maven/cli/transfer/Slf4jMavenTransferListener.java
            MNG-5457 Show repository id when downloading or uploading from/to a (schulte: rev ff5d215b54cb9a77e3742dc5dd05865dec08795b)
          • (edit) maven-embedder/src/main/java/org/apache/maven/cli/transfer/Slf4jMavenTransferListener.java
          • (edit) maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build maven-3.x #1456 (See https://builds.apache.org/job/maven-3.x/1456/ ) Revert " MNG-5457 Show repository id when downloading or uploading (schulte: rev 2385484a813edc157ba151c9daa0625eaf8902f9) (edit) maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java (edit) maven-embedder/src/main/java/org/apache/maven/cli/transfer/Slf4jMavenTransferListener.java MNG-5457 Show repository id when downloading or uploading from/to a (schulte: rev ff5d215b54cb9a77e3742dc5dd05865dec08795b) (edit) maven-embedder/src/main/java/org/apache/maven/cli/transfer/Slf4jMavenTransferListener.java (edit) maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build maven-plugins #7818 (See https://builds.apache.org/job/maven-plugins/7818/)
          MNG-5457 Show repository id when downloading or uploading from/to a remote repository

          o Updated to account for recent log messages in 3.4+. (schulte: http://svn.apache.org/viewvc/?view=rev&rev=1775953)

          • (edit) maven-deploy-plugin/src/it/MDEPLOY-202_deployfile-with-multiple-executions/verify.groovy
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build maven-plugins #7818 (See https://builds.apache.org/job/maven-plugins/7818/ ) MNG-5457 Show repository id when downloading or uploading from/to a remote repository o Updated to account for recent log messages in 3.4+. (schulte: http://svn.apache.org/viewvc/?view=rev&rev=1775953 ) (edit) maven-deploy-plugin/src/it/ MDEPLOY-202 _deployfile-with-multiple-executions/verify.groovy
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build maven-plugins #7823 (See https://builds.apache.org/job/maven-plugins/7823/)
          MNG-5457 Show repository id when downloading or uploading from/to a remote repository

          o Updated to account for recent log messages in 3.4+. (schulte: http://svn.apache.org/viewvc/?view=rev&rev=1775976)

          • (edit) maven-deploy-plugin/src/it/MDEPLOY-202_deployfile-with-multiple-executions/verify.groovy
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build maven-plugins #7823 (See https://builds.apache.org/job/maven-plugins/7823/ ) MNG-5457 Show repository id when downloading or uploading from/to a remote repository o Updated to account for recent log messages in 3.4+. (schulte: http://svn.apache.org/viewvc/?view=rev&rev=1775976 ) (edit) maven-deploy-plugin/src/it/ MDEPLOY-202 _deployfile-with-multiple-executions/verify.groovy
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build maven-plugins #8051 (See https://builds.apache.org/job/maven-plugins/8051/)
          MNG-5457 Show repository id when downloading or uploading from/to a remote repository

          o Updated to account for recent log messages in 3.4+. (schulte: http://svn.apache.org/viewvc/?view=rev&rev=1776211)

          • (edit) maven-dependency-plugin/src/it/projects/copy-from-remote-repository/verify.groovy
            MNG-5457 Show repository id when downloading or uploading from/to a remote repository

          o Updated to account for recent log messages in 3.4+. (schulte: http://svn.apache.org/viewvc/?view=rev&rev=1776210)

          • (edit) maven-dependency-plugin/src/it/projects/copy-from-remote-repository/verify.groovy
          • (edit) maven-dependency-plugin/src/it/projects/unpack-from-remote-repository/verify.groovy
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build maven-plugins #8051 (See https://builds.apache.org/job/maven-plugins/8051/ ) MNG-5457 Show repository id when downloading or uploading from/to a remote repository o Updated to account for recent log messages in 3.4+. (schulte: http://svn.apache.org/viewvc/?view=rev&rev=1776211 ) (edit) maven-dependency-plugin/src/it/projects/copy-from-remote-repository/verify.groovy MNG-5457 Show repository id when downloading or uploading from/to a remote repository o Updated to account for recent log messages in 3.4+. (schulte: http://svn.apache.org/viewvc/?view=rev&rev=1776210 ) (edit) maven-dependency-plugin/src/it/projects/copy-from-remote-repository/verify.groovy (edit) maven-dependency-plugin/src/it/projects/unpack-from-remote-repository/verify.groovy
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build maven-plugins #8116 (See https://builds.apache.org/job/maven-plugins/8116/)
          MNG-5457 Show repository id when downloading or uploading from/to a remote repository

          o Updated to make groovy scripts work with Windows paths. (schulte: http://svn.apache.org/viewvc/?view=rev&rev=1776328)

          • (edit) maven-dependency-plugin/src/it/projects/copy-from-remote-repository/verify.groovy
          • (edit) maven-dependency-plugin/src/it/projects/unpack-from-remote-repository/verify.groovy
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build maven-plugins #8116 (See https://builds.apache.org/job/maven-plugins/8116/ ) MNG-5457 Show repository id when downloading or uploading from/to a remote repository o Updated to make groovy scripts work with Windows paths. (schulte: http://svn.apache.org/viewvc/?view=rev&rev=1776328 ) (edit) maven-dependency-plugin/src/it/projects/copy-from-remote-repository/verify.groovy (edit) maven-dependency-plugin/src/it/projects/unpack-from-remote-repository/verify.groovy
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build maven-plugins #8122 (See https://builds.apache.org/job/maven-plugins/8122/)
          MNG-5457 Show repository id when downloading or uploading from/to a remote repository

          o Updated to correct groovy scripts. (schulte: http://svn.apache.org/viewvc/?view=rev&rev=1776354)

          • (edit) maven-dependency-plugin/src/it/projects/copy-from-remote-repository/verify.groovy
          • (edit) maven-dependency-plugin/src/it/projects/unpack-from-remote-repository/verify.groovy
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build maven-plugins #8122 (See https://builds.apache.org/job/maven-plugins/8122/ ) MNG-5457 Show repository id when downloading or uploading from/to a remote repository o Updated to correct groovy scripts. (schulte: http://svn.apache.org/viewvc/?view=rev&rev=1776354 ) (edit) maven-dependency-plugin/src/it/projects/copy-from-remote-repository/verify.groovy (edit) maven-dependency-plugin/src/it/projects/unpack-from-remote-repository/verify.groovy
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build maven-plugins #8197 (See https://builds.apache.org/job/maven-plugins/8197/)
          MNG-5457 Show repository id when downloading or uploading from/to a remote repository

          o Updated to correct groovy scripts. (schulte: http://svn.apache.org/viewvc/?view=rev&rev=1776513)

          • (edit) maven-dependency-plugin/src/it/projects/copy-from-remote-repository/verify.groovy
          • (edit) maven-dependency-plugin/src/it/projects/unpack-from-remote-repository/verify.groovy
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build maven-plugins #8197 (See https://builds.apache.org/job/maven-plugins/8197/ ) MNG-5457 Show repository id when downloading or uploading from/to a remote repository o Updated to correct groovy scripts. (schulte: http://svn.apache.org/viewvc/?view=rev&rev=1776513 ) (edit) maven-dependency-plugin/src/it/projects/copy-from-remote-repository/verify.groovy (edit) maven-dependency-plugin/src/it/projects/unpack-from-remote-repository/verify.groovy
          Hide
          stephenc Stephen Connolly added a comment -

          Maven 3.4.0 has been dropped. See this thread for more details.

          This issue will need to be re-scheduled for a Maven release in the (hopefully near) future.

          Show
          stephenc Stephen Connolly added a comment - Maven 3.4.0 has been dropped. See this thread for more details. This issue will need to be re-scheduled for a Maven release in the (hopefully near) future.
          Hide
          stephenc Stephen Connolly added a comment -

          Any reason why this cannot be merged for 3.5.1?

          Show
          stephenc Stephen Connolly added a comment - Any reason why this cannot be merged for 3.5.1?
          Hide
          michael-o Michael Osipov added a comment - - edited

          This requires a new Maven Resolver version. I have already implemented the change before Resolver master was reset.

          Show
          michael-o Michael Osipov added a comment - - edited This requires a new Maven Resolver version. I have already implemented the change before Resolver master was reset.
          Hide
          hboutemy Hervé Boutemy added a comment -

          MRESOLVER-2 would be an issue I'd second for the next Maven Resolver release!

          Show
          hboutemy Hervé Boutemy added a comment - MRESOLVER-2 would be an issue I'd second for the next Maven Resolver release!
          Hide
          michael-o Michael Osipov added a comment -
          Show
          michael-o Michael Osipov added a comment - Fixed with b1002575177abd1108fe50f457cceb9c7c3cf7d8 .
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build maven-3.x #1659 (See https://builds.apache.org/job/maven-3.x/1659/)
          MNG-5457 Show repository id when downloading or uploading from/to a (michaelo: http://git-wip-us.apache.org/repos/asf/?p=maven.git&a=commit&h=b1002575177abd1108fe50f457cceb9c7c3cf7d8)

          • (edit) maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java
          • (edit) maven-embedder/src/main/java/org/apache/maven/cli/transfer/Slf4jMavenTransferListener.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build maven-3.x #1659 (See https://builds.apache.org/job/maven-3.x/1659/ ) MNG-5457 Show repository id when downloading or uploading from/to a (michaelo: http://git-wip-us.apache.org/repos/asf/?p=maven.git&a=commit&h=b1002575177abd1108fe50f457cceb9c7c3cf7d8 ) (edit) maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java (edit) maven-embedder/src/main/java/org/apache/maven/cli/transfer/Slf4jMavenTransferListener.java
          Hide
          vinayshankar Vinay Shankar added a comment -

          Michael Osipov - Could you create a PR for the commits if they have not been merged yet? According to the link https://issues.apache.org/jira/projects/MNG/versions/12338964, the 3.5.1 release is pending due to unreviewed commits from MNG-5457.

          3.5.0 has a MAJOR bug (MNG-6240 and MDEPLOY-221) and a 3.5.1 release will be very useful.

          Show
          vinayshankar Vinay Shankar added a comment - Michael Osipov - Could you create a PR for the commits if they have not been merged yet? According to the link https://issues.apache.org/jira/projects/MNG/versions/12338964 , the 3.5.1 release is pending due to unreviewed commits from MNG-5457 . 3.5.0 has a MAJOR bug ( MNG-6240 and MDEPLOY-221 ) and a 3.5.1 release will be very useful.
          Hide
          michael-o Michael Osipov added a comment -

          This one has already been fixed and merged.

          Show
          michael-o Michael Osipov added a comment - This one has already been fixed and merged.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user rfscholte commented on the issue:

          https://github.com/apache/maven/pull/87

          @rajivpjs can you close this pullrequest? This open PR causes warnings for https://issues.apache.org/jira/browse/MNG-5457 on the release page.

          Show
          githubbot ASF GitHub Bot added a comment - Github user rfscholte commented on the issue: https://github.com/apache/maven/pull/87 @rajivpjs can you close this pullrequest? This open PR causes warnings for https://issues.apache.org/jira/browse/MNG-5457 on the release page.

            People

            • Assignee:
              michael-o Michael Osipov
              Reporter:
              hboutemy Hervé Boutemy
            • Votes:
              3 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development