[MNG-5314] DefaultModelValidator misuses String.matches

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.0.4
• Fix Version/s: 3.1.0-alpha-1
• Component/s: Bootstrap & Build
• Flags: Patch
• Assignee: Jason van Zyl
• Reporter: Jesse N. Glick
• Created: 17/Jul/12 15:43
• Updated: 07/Apr/15 12:25
• Resolved: 18/Jul/12 07:42

Description

While investigating MNG-5312, a profiler run turned up tens of thousands of calls to DefaultModelValidator.validateId consuming a considerable portion of total CPU time. Turns out the existing code uses String.matches, which recompiles the regex on each call, which is far more expensive than applying a precompiled pattern. A trivial fix makes this method disappear from the hot spots shown by the profiler, though the fix of MNG-5312 of course means that there would be far fewer calls to this method to begin with.

Issue Links

• relates to: MNG-5312 MavenProject.getParent intolerably slow when import scope used heavily